upgrade: polkadot-sdk deps to stable2503 #671
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
added
B5-clientnoteworthy
This commit fixes multiple build issues that arose from the polkadot-sdk stable2503 upgrade when running `cargo test --features runtime-benchmarks`. Changes: 1. Downgrade Rust to 1.90 (from 1.91) - polkavm-linker generates target specs with "target-pointer-width": "64" (string) - Rust 1.91 (PR #144443) changed this to require an integer - Added documentation explaining this incompatibility in rust-toolchain.toml 2. Add `extern crate alloc;` to pallets - Required after polkadot-sdk PR #7043 removed sp-std - Added to: bucket-nfts, file-system, providers 3. Fix benchmark helper trait bounds - pallet_nfts now requires BenchmarkHelper impl for test signature types - Added TestNftsBenchmarkHelper to payment-streams and file-system precompile mocks 4. Fix proofs-dealer benchmark constraints - Changed ForestVerifier proof type from CompactProof to ShpCompactProof - ShpCompactProof implements DecodeWithMemTracking required by stable2503 5. Trim runtime benchmarks to StorageHub pallets only - Removed frame_system, pallet_balances, and other non-StorageHub pallets - Reduces benchmark maintenance burden 6. Remove rococo-native feature from polkadot-cli - Avoids pallet-xcm -> pallet-revive dependency chain - External relay chain via zombienet/RPC still works 7. Add runtime-benchmarks feature to file-system precompile - Required for proper feature propagation Co-Authored-By: Claude Opus 4.5 <[email protected]>
1. Set XcmEventEmitter to pallet_xcm::Pallet<Runtime> in parachain and xcm-simulator XCM configs for proper XCM event emission
2. Update relay token reserve transfer test to reflect stable2503 behavior:
- Network native asset reserve transfers are now blocked at pallet_xcm
level with InvalidAssetUnknownReserve (Asset Hub Migration prep, PR #9544)
- Test now expects failure at source rather than at destination
- Balances remain unchanged since transfer is rejected early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.