Skip to content

⚡ Bolt: [performance improvement] Optimize string escaping in TestFileNamePatternParser #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RoiSoleil wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

⚡ Bolt: [performance improvement] Optimize string escaping in TestFileNamePatternParser #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions org.moreunit.core/src/org/moreunit/core/matching/TestFileNamePatternParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
public class TestFileNamePatternParser
{
public static final String SRC_FILE_VARIABLE = "${srcFile}";
private static final Pattern CHARS_TO_ESCAPE = Pattern.compile("([\\*\\(\\)\\|])");

private final String patternToParse;
private final NameTokenizer tokenizer;

Expand Down Expand Up @@ -151,7 +149,11 @@ private UserDefinedPart(String str, String separator)

private static String escapeCharsWhereNeeded(String str)
{
return CHARS_TO_ESCAPE.matcher(str).replaceAll(quoteReplacement("\\$1"));
// PERFORMANCE: Use chained literal String.replace instead of regex Matcher.replaceAll
return str.replace("*", "\\*")
.replace("(", "\\(")
.replace(")", "\\)")
.replace("|", "\\|");
}

private void parse()
Expand Down
Loading