Add Grammar chapter: relative & demonstrative pronouns (closes #26, #27, #8) - #33
Conversation
New `grammar.qmd` chapter (with modular `grammar/` include files) covering: - Relative pronouns: restrictive *that* vs. non-restrictive *which*, and keeping the relative pronoun rather than omitting it. - Demonstrative pronouns: name the referent instead of using a bare *this*/*that* as a standalone pronoun. Follows the established chapter conventions (AI-assistance disclaimer include, Quarto `#exm-` example environments, modular section includes) and registers the chapter in _quarto.yml between word-choice and conciseness. Verified with `quarto render --to html`. Closes #26, #27, #8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018v7h9ZVVQRBjdyRFGXCrzG
The Texas A&M demonstratives guide URL (carried over from issue #8) returns 404 — the page has moved — which failed the lychee link-checker. The chapter's example already makes the point, and the other chapters cite no external grammar guides, so drop the link rather than chase a bot-blocked replacement. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018v7h9ZVVQRBjdyRFGXCrzG
… layout main restructured the project from a Quarto `book` into the website-profile layout (PR #28): content pages moved under `chapters/`, the chapter list moved out of `_quarto.yml` (now `profile: default: website`) into the `_quarto-website.yml` navbar, and pages now carry per-format front matter. Resolved the `_quarto.yml` conflict by taking main's profile-based config, and adapted the new Grammar chapter to the website layout: - Moved `grammar.qmd` -> `chapters/grammar.qmd` and `grammar/` -> `chapters/grammar/` (include partials). - Replaced the `# Grammar` book heading with website-style front matter (`title:` + html/revealjs/pdf/docx `output-file` stems), matching the other chapters. - Registered "Grammar" in the `_quarto-website.yml` navbar between Word choice and Conciseness, and excluded `chapters/grammar/` from direct render (it holds include partials only), mirroring `chapters/defining-terms/`. - Added "overfit" to `inst/WORDLIST` for the spell-check. Verified with `quarto render chapters/grammar.qmd --to html` (examples 6.x render and cross-reference) and a local `spelling` pass.
…aude/grammar-pronouns
|
Claude finished @d-morrison's task in 3m 52s —— View job Code Review: PR #33 — Grammar chapter (relative & demonstrative pronouns)
Overall verdictThe chapter is clean and well-structured. Front matter stems are consistent (
Findings #1 and #2 are debatable: these are parenthetical enumerations embedded in a sentence, not standalone lists, so there's a reasonable argument they're a deliberate exception to the bullet-list rule. Finding #3 is the most concrete omission — the link was described in the PR but not implemented. To kick off a follow-up fix run: |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Address review feedback on #33. CLAUDE.md asks for bullet lists rather than comma-separated prose when enumerating 3+ items. The chapter introductions listed the relative pronouns (5 items) and the demonstrative words (4 items) as inline parentheticals; pull each into a bullet list so the chapter follows its own style rule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DumtSMxBrkiC5c3fnxBwYu
|
Claude finished @d-morrison's task in 1m 56s —— View job Review of updated PR #33Checked all four findings from the prior review against the current branch state.
Finding #1 — Relative pronouns enumeration (bullet list)Resolved. Finding #2 — Demonstrative pronouns enumeration (bullet list)Resolved. Finding #3 — Missing Texas A&M demonstratives linkResolved by removal. Commit Finding #4 —
|
|
2 participants
Summary
Adds a new Grammar chapter covering three open grammar issues about pronouns. New
grammar.qmdwith modulargrammar/include files, registered in_quarto.ymlbetween word choice and conciseness.Content
Relative pronouns (
grammar/relative-pronouns.qmd)thatfor restrictive clauses (no comma),whichfor non-restrictive clauses (set off by commas), with worked examples and a quick drop-the-clause test.that/which/whoeven when grammar permits dropping them, using the issue's own "methodological groundwork that I now apply to enteric fever" example.Demonstrative pronouns (
grammar/demonstrative-pronouns.qmd) (#8)this/thatstanding alone as a pronoun; name the referent ("This overfitting poses a problem" rather than "This poses a problem"). (The Texas A&M demonstratives guide cited in the issue 404s/403s and fails the lychee link-checker, so it was dropped in 7131a6a; the worked example carries the point on its own.)Conventions followed
#exm-example environments (not bold labels), percopilot-instructions.md.quarto render --to html— renders as chapter 6 with examples 6.1–6.4 numbered and cross-referenceable.Closes
Closes #26, Closes #27, Closes #8.
🤖 Generated with Claude Code