Skip to content

Update dependencies in copilot-setup-steps.yml - #45

Merged
d-morrison merged 3 commits into
mainfrom
d-morrison-patch-2
May 4, 2026
Merged

Update dependencies in copilot-setup-steps.yml#45
d-morrison merged 3 commits into
mainfrom
d-morrison-patch-2

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Added additional dependencies for OCR and documentation tools.

Added additional dependencies for OCR and documentation tools.
Copilot AI review requested due to automatic review settings May 4, 2026 05:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Copilot coding-agent setup workflow to install additional Ubuntu system packages needed for OCR and documentation-related tooling.

Changes:

  • Extend the apt-get install package list with OCR utilities (Poppler, Tesseract) and other tools.
  • Add maxima and python3-pip to the agent environment dependencies.

Comment thread .github/workflows/copilot-setup-steps.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/copilot-setup-steps.yml
@d-morrison
d-morrison merged commit 1e9d6f9 into main May 4, 2026
8 checks passed
@d-morrison
d-morrison deleted the d-morrison-patch-2 branch May 4, 2026 05:20
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-04 05:23 UTC

d-morrison added a commit that referenced this pull request Aug 8, 2026
Phase 2 of the qwt -> gha migration (#116). All three blockers are now
closed (gha#43/#44/#45), so these can move to thin callers of the
reusable workflows:

- summary.yml -> Morrison-Lab/gha/.github/workflows/summary.yml@v1
  (unchanged since the v1 freeze per gha's README Versioning section;
  the reusable version already has the nonce-based prompt-injection
  hardening and blank-response guard qwt's own copy had grown).
- claude.yml -> .../claude.yml@v2 (picked up a real fix since the v1
  freeze, per gha's README). The reusable workflow now owns branch
  setup + draft-PR opening for issue triggers, posting Claude's prose
  reply, review dispatch on "@claude review", and the late-comment
  dedup/rescue machinery that gha originally ported FROM this repo's
  own #73/#90/#95.
- claude-code-review.yml -> .../claude-code-review.yml@v2 (same v2
  rationale). Draft/fork/Dependabot/self-edit skip logic is now
  handled inside the reusable workflow; this caller only supplies the
  qwt-specific Quarto/R/build-hygiene/CI review guidance and the
  ready-to-paste "@claude address review comments" draft convention
  via prompt-addendum.

Deviates from the issue's literal checklist in two places, per gha's
current README (written after the issue was filed):
- claude.yml/claude-code-review.yml pin @v2, not @v1 -- @v2 has fixes
  @v1 lacks (gha#182).
- Secrets are passed explicitly rather than via `secrets: inherit`:
  GitHub only inherits secrets into a same-owner reusable workflow,
  and Morrison-Lab/gha is a different owner than d-morrison/qwt.

Behavior change: claude.yml now defaults mark-ready-for-review: true,
so an issue-triggered draft PR is taken out of draft once Claude
commits code (previously always left as a draft).

Net: -835/+115 lines across the three files; qwt's hand-rolled
dedup/branch/PR/review-dispatch logic is now upstream in gha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants