Skip to content

docs(agents): review Citadel and the five levels of Claude Code use (closes #102) - #231

Open
dem-extra1 wants to merge 4 commits into
mainfrom
review-citadel-102
Open

docs(agents): review Citadel and the five levels of Claude Code use (closes #102)#231
dem-extra1 wants to merge 4 commits into
mainfrom
review-citadel-102

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Reviews Citadel (SethGammon/Citadel) and the "five levels of Claude Code" maturity model from the r/ClaudeAI post issue #102 links, then places the lab's own Morrison-Lab/ai-config setup on that ladder and says what the next level would take. Adds one fragment under chapters/ai-tools/, included after the best-practices section, with citations for every source actually fetched.

Closes #102

🤖 Generated with Claude Code

…closes #102)

Issue #102 asked for a review of SethGammon/Citadel and of a Reddit post on
five maturity levels of Claude Code use. The lab keeps returning to the
underlying question of how much machinery to build around an agent, so the
review lands as a fragment that explains what Citadel adds, what its own
evidence does and does not show, and where Morrison-Lab/ai-config sits on
Citadel's orchestration ladder.

The Reddit post was unreachable from this network on 2026-09-09 (every route
to reddit.com returned a network-security block), so the five-level model is
deferred to #227 and the fragment says so rather than paraphrasing a post
nobody read.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 10, 2026 06:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are documentation and bibliography consistency issues (section heading scope mismatch; BibTeX howpublished convention drift) that should be corrected before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a new documentation fragment reviewing the Citadel project and uses it to situate Morrison-Lab/ai-config on an “agent orchestration ladder” within the Quarto site’s coding-agents chapter.

Changes:

  • Add new Citadel-focused fragment under chapters/ai-tools/ and include it in chapters/coding-agents.qmd.
  • Add new BibTeX entries for Citadel’s repo and key docs (architecture, experiments, threat model).
  • Introduce a new top-level section in the coding-agents chapter to surface the fragment.
File summaries
File Description
references.bib Adds Citadel bibliography entries for repo + docs (needs howpublished convention alignment for the repo entry).
chapters/coding-agents.qmd Inserts a new section and includes the new Citadel fragment (heading currently overpromises “levels” content).
chapters/ai-tools/citadel-and-maturity-levels.qmd New fragment describing Citadel and an orchestration ladder, plus how the lab’s setup maps to it.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +88 to +90
# Citadel and Levels of Claude Code Use {#sec-ai-citadel-and-maturity-levels}

{{< include ai-tools/citadel-and-maturity-levels.qmd >}}
Comment thread references.bib Outdated
Comment on lines +262 to +269
@misc{citadel_repo,
title = {Citadel: An open-source operating layer for Claude Code and OpenAI Codex},
author = {Gammon, Seth},
year = {2026},
howpublished = {GitHub repository},
url = {https://github.com/SethGammon/Citadel},
note = {MIT License. Release v1.3.5. Accessed 2026-09-09}
}
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…wordlist entries

The review verified the "does not replace CLAUDE.md ..." sentence
lives in the README rather than THREAT_MODEL.md, so it now cites the
repository entry. "candour" becomes "candor" to match the corpus,
the four author fields use the file's "Firstname Lastname" form, and
the seven new terms the Spellcheck job flagged are added to the
wordlist.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings September 10, 2026 07:06
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new citadel_repo bibliography entry uses a howpublished value inconsistent with the repository’s established references.bib convention for GitHub repositories.

Review details

Suppressed comments (1)

references.bib:266

  • This new GitHub repository citation uses howpublished = {GitHub repository}, but other GitHub repository entries in this bibliography use howpublished = {Software} (while docs pages use {Documentation}). Keeping the existing convention will make citation formatting consistent across the site.
  howpublished = {GitHub repository},
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

There are documentation/bibliography consistency issues (misleading section title and a non-standard howpublished value) that should be corrected before merge.

Review details

Suppressed comments (2)

references.bib:268

  • In references.bib, GitHub repository citations elsewhere use howpublished = {Software} (e.g., inflexa/torqclaw). This new Citadel repository entry uses {GitHub repository}, which is inconsistent and may break downstream formatting expectations.
@misc{citadel_repo,
  title = {Citadel: An open-source operating layer for Claude Code and OpenAI Codex},
  author = {Seth Gammon},
  year = {2026},
  howpublished = {GitHub repository},
  url = {https://github.com/SethGammon/Citadel},
  note = {MIT License. Release v1.3.5. Accessed 2026-09-09}

chapters/coding-agents.qmd:90

  • This section title implies the r/ClaudeAI “five maturity levels of Claude Code use” are covered here, but the included fragment says the post could not be fetched and the five-level model is tracked separately in #227. Consider renaming the section heading so it matches the actual content (Citadel + its ladder) and doesn’t suggest the Reddit model is included.
# Citadel and Levels of Claude Code Use {#sec-ai-citadel-and-maturity-levels}

{{< include ai-tools/citadel-and-maturity-levels.qmd >}}
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 10, 2026 08:11
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces a few documentation/convention mismatches (list-formatting convention, section heading accuracy, and bibliography howpublished convention) that should be corrected before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

chapters/coding-agents.qmd:92

  • This section heading implies the included content covers the “levels of Claude Code use”, but the included fragment explicitly says the Reddit five-level model could not be fetched and is tracked separately in #227 (chapters/ai-tools/citadel-and-maturity-levels.qmd:11-17). Consider renaming the heading so the chapter navigation matches what the section actually discusses.
# Citadel and Levels of Claude Code Use {#sec-ai-citadel-and-maturity-levels}

references.bib:237

  • This entry cites a GitHub repository, but references.bib consistently uses howpublished = {Software} for GitHub repo citations (e.g., inflexa at references.bib:93-100 and torqclaw at references.bib:101-108). Using a new howpublished value (“GitHub repository”) breaks that convention and may render inconsistently.
  howpublished = {GitHub repository},
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment on lines +1 to +4
Every lab that uses a coding agent for more than one-off edits
eventually builds something around it:
instruction files, then skills, then hooks, then scripts that watch pull requests.
@sec-ai-customization maps those mechanisms one at a time.
The union resolver used for the sync dropped the blank line between
every pre-existing entry and truncated one entry, which made pandoc
reject the file and failed the build. The file is now rebuilt from
the two parent versions: main's entries in main's order and formatting,
then this branch's new entries appended, validated with pandoc.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings September 10, 2026 08:33
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Confirms the only substantive change since the last review round is the references.bib reformatting/reordering to resolve a merge with main — no content changes to the chapter, wordlist, or citation text.

Review: PR #231docs(agents): review Citadel and the five levels of Claude Code use (closes #102)

What changed since the last round

Per the computed range 4dce861e..97654a7e, the only file touched is references.bib (commit b00f400, "fix(bib): rebuild references.bib as a clean union after the main sync"). I diffed it directly: it's a pure reformatting/reordering of existing entries (adding blank lines between all @misc{...} blocks for consistent spacing, and relocating the four citadel_* entries from the middle of the file to the end) plus the entries newly synced in from main (oh_my_claudecode, hoyeon, superpowers, gsd_core, openharness, langchain_custom_harness, my_claude_code_harness). No entry's field content changed.

I verified the rebuild is structurally sound:

  • Brace count is balanced (297 open / 297 close).
  • 40 @misc{...} entries, all with unique keys — no duplicates survived the union/merge.
  • File ends with a single clean trailing newline, no stray merge-conflict markers.
  • All three findings from the prior two review rounds remain fixed in this checkout: the citadel_repo/citadel_architecture/citadel_experiments/citadel_threat_model entries still use author = {Seth Gammon} (not inverted form), chapters/ai-tools/citadel-and-maturity-levels.qmd:119 still correctly cites [@citadel_repo] for the README quote, and inst/WORDLIST still contains all the previously-flagged words (Archon, Dependabot, inspectable, journaled, recoverability, resumable, runtime's) with candour nowhere in the prose.

No new issues introduced by this round's change. The prior verdict — Ready for merge, posted at this review, commit 79ca4a00901d38c4b61fa32f983c8967bb32857d — still stands; this round's references.bib rebuild is a mechanical merge-conflict fix with no regressions.

Verdict

Ready for merge — the only change since the last clean review is a mechanical references.bib rebuild after syncing with main, verified structurally sound with no duplicate keys, no content drift, and all prior findings still resolved.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "97654a7e6ef24fba49f572ca37cb5b8f8b0012f1",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "references.bib was rebuilt as a union after a main-branch sync; brace balance, unique keys, and trailing newline were all verified programmatically with no corruption.",
  "holistic_assessment": "Scope stayed limited to bibliography formatting from a merge, prior citation and wordlist fixes remain intact, and no regression was introduced against the previously approved diff."
}

Reviewed commit: b00f400

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3115 (review) — run

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new Citadel repository bibliography entry uses a howpublished value that is inconsistent with established references.bib conventions for GitHub repositories.

Review details

Suppressed comments (1)

references.bib:332

  • references.bib uses howpublished = {Software} for GitHub repository citations (e.g., inflexa, torqclaw, openharness, my_claude_code_harness), but this new entry uses howpublished = {GitHub repository}. This makes the bibliography inconsistent and may change how the citation renders.
@misc{citadel_repo,
  title = {Citadel: An open-source operating layer for Claude Code and OpenAI Codex},
  author = {Seth Gammon},
  year = {2026},
  howpublished = {GitHub repository},
  url = {https://github.com/SethGammon/Citadel},
  note = {MIT License. Release v1.3.5. Accessed 2026-09-09}
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Morrison-Lab.github.io/wai/pr-preview/pr-231/

Built to branch gh-pages at 2026-09-10 08:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review https://github.com/SethGammon/Citadel

2 participants