Add ARIA attributes to dropdown components - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds comprehensive accessibility improvements to dropdown components, addressing issue #162 and ensuring WCAG 2.1 Level A compliance.
Changes
Components Updated
LanguageSwitcher
NetworkSelector
MarketFilter
New Features
Reusable Hook
Utility Functions
Components
Hooks
Testing
Documentation
Styling
WCAG Compliance
This implementation meets the following WCAG 2.1 criteria:
✅ 4.1.2 Name, Role, Value (Level A)
✅ 2.1.1 Keyboard (Level A)
✅ 2.4.3 Focus Order (Level A)
✅ 2.4.7 Focus Visible (Level AA)
Benefits
Testing
Manual Testing
Automated Testing
All tests passing:
Files Changed
Components (3 updated, 3 new)
Hooks (3 new)
Utilities (3 new)
Tests (4 new)
Documentation (5 new)
Styles (1 new)
Migration Path
Existing dropdowns can be easily migrated using the new hook:
See DROPDOWN_MIGRATION_GUIDE.md for detailed instructions.
Closes #162