Fix/keyboard navigation custom components - #196
Merged
Conversation
…, and chart legend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components converted from div/span to button:
MarketFilter.tsx — CategoryOption and SortOptionItem
AMMComponents.tsx — AMMPoolCard (already done in prior PR)
ResponsiveChart.tsx — CompactIndicatorPanel indicator badge (already done)
RBACExamples.tsx — APIServiceExample and ValidationExample interactive divs
role="button" divs given onKeyDown + proper attributes:
WizardProgress.tsx — step items (Enter/Space + aria-current)
DisputeCard.tsx — expand toggle (Enter/Space + aria-expanded)
OracleCard.tsx — compact and full card variants
ProposalCard.tsx — proposal card
OracleHealthDashboard.tsx — provider cards
IndicatorPanel.tsx — indicator header expand toggle
DrawingToolsPanel.tsx — tool header expand toggle
RoleManagementDashboard.tsx — role selection cards
ChartLegend.tsx — indicator toggle items
Modal/overlay backdrops given Escape key + role="presentation":
MobileBottomSheet.tsx
MobileModal.tsx
NetworkSwitchDialog.tsx
GovernancePage.tsx — proposal detail modal and delegate modal (also added role="dialog" + aria-modal)
Sortable table headers:
AuditLogViewer.tsx — tabIndex, onKeyDown, aria-sort on all three sortable th elements
Closes #163