Skip to content

Report versioning #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epou merged 1 commit into from
Oct 23, 2024
Merged

Report versioning #201

epou merged 1 commit into from
Oct 23, 2024

Conversation

@epou
Copy link
Member

@epou epou commented Jan 26, 2024 •
edited
Loading

Before merging check that:

  • All created reports have "CREATE" histories: 
    SELECT "tigaserver_app_report"."version_UUID", "server_upload_time",(SELECT COUNT(1) AS "count" FROM "tigaserver_app_historicalreport" U0 WHERE U0."version_UUID" = ("tigaserver_app_report"."version_UUID")) AS "count" FROM "tigaserver_app_report" WHERE (SELECT COUNT(1) AS "count" FROM "tigaserver_app_historicalreport" U0 WHERE U0."version_UUID" = ("tigaserver_app_report"."version_UUID")) = '0';
  • There are no histories referring to non existing reports: 
    SELECT DISTINCT(tigaserver_app_historicalreport."version_UUID") FROM tigaserver_app_historicalreport LEFT JOIN tigaserver_app_report ON tigaserver_app_report."version_UUID" = tigaserver_app_historicalreport."version_UUID" WHERE tigaserver_app_report."version_UUID" IS NULL;

@epou epou self-assigned this Jan 26, 2024
@epou epou force-pushed the report_versioning branch 2 times, most recently from 4f1af4b to 922c737 Compare January 26, 2024 16:15
@epou epou force-pushed the report_versioning branch from 9bd3bb7 to 052ebb2 Compare January 30, 2024 10:44
@epou epou force-pushed the v1_improvements branch 2 times, most recently from e5d9e96 to 644e7e9 Compare February 14, 2024 11:09
@epou epou force-pushed the report_versioning branch from 052ebb2 to a57b945 Compare February 20, 2024 11:58
@epou epou changed the base branch from v1_improvements to refactor_report_responses February 20, 2024 12:20
@epou epou force-pushed the report_versioning branch 2 times, most recently from 60a398c to 898eb0c Compare February 20, 2024 14:29
@epou epou force-pushed the refactor_report_responses branch from f3ce405 to 9e701f4 Compare February 20, 2024 14:32
@epou epou force-pushed the report_versioning branch from 898eb0c to 7f19e03 Compare February 20, 2024 15:34
@epou epou force-pushed the refactor_report_responses branch from 9e701f4 to f54fc58 Compare February 20, 2024 15:35
@epou epou force-pushed the report_versioning branch 3 times, most recently from 721f622 to cc888ac Compare February 21, 2024 15:10
@codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.47059% with 66 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (2c83ba9) to head (e63dcbf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
tigaserver_app/serializers.py 22.22% 21 Missing ⚠️
tigaserver_app/views.py 55.26% 17 Missing ⚠️
tigamap/views.py 0.00% 8 Missing ⚠️
tigacrafting/views.py 0.00% 7 Missing ⚠️
tigaserver_app/admin.py 60.00% 4 Missing ⚠️
tigaserver_app/models.py 84.61% 4 Missing ⚠️
tigacrafting/criteria.py 0.00% 3 Missing ⚠️
tigascoring/xp_scoring.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   43.75%   43.82%   +0.07%     
==========================================
  Files          62       62              
  Lines       10360    10370      +10     
==========================================
+ Hits         4533     4545      +12     
+ Misses       5827     5825       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epou epou force-pushed the refactor_report_responses branch from 7ee19fb to 5d5cc1c Compare October 22, 2024 09:42
@epou epou changed the base branch from refactor_report_responses to master October 22, 2024 15:16
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 22, 2024
View reviewed changes
stats/templates/stats/mosquito_ccaa_rich.html
<script src="//code.highcharts.com/highcharts.js"></script>
<script src="//code.highcharts.com/maps/modules/map.js"></script>
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/mosquito_ccaa_rich_iframetest_sites.html
<link rel="stylesheet" href="{% static 'tigacrafting/bootstrap-select/css/bootstrap-select.min.css' %}">
<link rel="stylesheet" href="{% static 'stats/mosquito_ccaa_rich_iframetest.css' %}">
<script src="//code.jquery.com/jquery-3.2.1.min.js"></script>
<script src="https://code.jquery.com/jquery-3.2.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/report_stats_ccaa_pie.html
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/report_stats_ccaa_pie_sites.html
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/speedmeter.html
<script src="//code.highcharts.com/highcharts.js"></script>
<script src="//code.highcharts.com/highcharts-more.js"></script>
<script src="//code.highcharts.com/modules/solid-gauge.js"></script>
<script src="https://code.jquery.com/jquery-3.2.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/sunburst.html
<script src="//code.highcharts.com/modules/sunburst.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
tigacrafting/static/tigacrafting/jquery_blockUI/jquery.blockUI.js
else
lyr3.append(msg);
if (msg.jquery || msg.nodeType)
$(msg).show();

Check warning

Code scanning / CodeQL

Unsafe jQuery plugin Medium

Potential XSS vulnerability in the
'$.fn.block' plugin
Loading
.
@epou epou force-pushed the report_versioning branch 4 times, most recently from 4302d31 to 7c3f5d2 Compare October 23, 2024 09:38
@epou epou marked this pull request as ready for review October 23, 2024 09:39
@epou epou force-pushed the report_versioning branch 2 times, most recently from 00abf15 to 70ec099 Compare October 23, 2024 10:18
@epou epou force-pushed the report_versioning branch from 70ec099 to e63dcbf Compare October 23, 2024 11:46
@epou epou merged commit c61ca61 into master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@epou epou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@epou