Skip to content

Refactor report responses #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epou merged 6 commits into from
Oct 22, 2024
Merged

Refactor report responses #207

epou merged 6 commits into from
Oct 22, 2024

Conversation

@epou
Copy link
Member

@epou epou commented Feb 13, 2024

No description provided.

@epou epou self-assigned this Feb 13, 2024
@epou epou force-pushed the v1_improvements branch 2 times, most recently from e5d9e96 to 644e7e9 Compare February 14, 2024 11:09
@epou epou force-pushed the refactor_report_responses branch 2 times, most recently from 3d6e9d1 to c26de1c Compare February 19, 2024 14:08
@epou epou changed the base branch from v1_improvements to master February 19, 2024 14:09
@epou epou force-pushed the refactor_report_responses branch from c26de1c to 063287b Compare February 19, 2024 14:13
@codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.16514% with 113 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (5d59696) to head (c5ce0c9).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
tigaserver_app/models.py 47.79% 83 Missing ⚠️
tigaserver_app/admin.py 26.66% 22 Missing ⚠️
tigaserver_app/serializers.py 50.00% 4 Missing ⚠️
tigascoring/xp_scoring.py 57.14% 3 Missing ⚠️
tigacrafting/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   43.58%   43.75%   +0.16%     
==========================================
  Files          62       62              
  Lines       10265    10360      +95     
==========================================
+ Hits         4474     4533      +59     
- Misses       5791     5827      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epou epou force-pushed the refactor_report_responses branch 4 times, most recently from d670bfc to f3ce405 Compare February 20, 2024 10:43
@epou epou requested a review from aescobarr February 20, 2024 11:02
@epou epou force-pushed the refactor_report_responses branch 2 times, most recently from 9e701f4 to f54fc58 Compare February 20, 2024 15:35
epou
epou commented Mar 12, 2024
View reviewed changes
@epou epou marked this pull request as draft March 18, 2024 14:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 22, 2024
View reviewed changes
stats/templates/stats/mosquito_ccaa_rich.html
<script src="//code.highcharts.com/highcharts.js"></script>
<script src="//code.highcharts.com/maps/modules/map.js"></script>
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/mosquito_ccaa_rich_iframetest_sites.html
<link rel="stylesheet" href="{% static 'tigacrafting/bootstrap-select/css/bootstrap-select.min.css' %}">
<link rel="stylesheet" href="{% static 'stats/mosquito_ccaa_rich_iframetest.css' %}">
<script src="//code.jquery.com/jquery-3.2.1.min.js"></script>
<script src="https://code.jquery.com/jquery-3.2.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/report_stats_ccaa_pie.html
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/report_stats_ccaa_pie_sites.html
<script src="//code.highcharts.com/mapdata/countries/es/es-all.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/speedmeter.html
<script src="//code.highcharts.com/highcharts.js"></script>
<script src="//code.highcharts.com/highcharts-more.js"></script>
<script src="//code.highcharts.com/modules/solid-gauge.js"></script>
<script src="https://code.jquery.com/jquery-3.2.1.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
stats/templates/stats/sunburst.html
<script src="//code.highcharts.com/modules/sunburst.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/proj4js/2.3.15/proj4.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
tigacrafting/static/tigacrafting/jquery_blockUI/jquery.blockUI.js
else
lyr3.append(msg);
if (msg.jquery || msg.nodeType)
$(msg).show();

Check warning

Code scanning / CodeQL

Unsafe jQuery plugin Medium

Potential XSS vulnerability in the
'$.fn.block' plugin
Loading
.
@epou epou force-pushed the refactor_report_responses branch from 7ee19fb to 5d5cc1c Compare October 22, 2024 09:42
@epou epou marked this pull request as ready for review October 22, 2024 12:07
@epou epou force-pushed the refactor_report_responses branch from 2329e5f to 3df466e Compare October 22, 2024 14:18
@epou epou merged commit 09f1dc8 into master Oct 22, 2024
6 checks passed
epou added a commit that referenced this pull request Oct 23, 2024
@epou
Make all new Report fields able to be blank. Relates #207.
2c83ba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aescobarr aescobarr Awaiting requested review from aescobarr

Assignees

@epou epou

Labels

type: feature request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@epou