Skip to content

Conversation

@epou
Copy link
Member

@epou epou commented Aug 22, 2025

No description provided.

@epou epou requested a review from Copilot August 22, 2025 10:58
@epou epou self-assigned this Aug 22, 2025

This comment was marked as outdated.

@epou epou force-pushed the fix_package_version branch from f8e5452 to a47f345 Compare August 22, 2025 11:10
@epou epou requested a review from Copilot August 22, 2025 11:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MobileApp.package_version field from a string field to a semantic version field to maintain compatibility with the Report.package_version integer field. The change ensures proper version handling by converting legacy integer versions to semantic versions with a "legacy" build identifier.

  • Converts MobileApp.package_version from CharField to VersionField using semantic versioning
  • Updates all test data to use proper semantic version format (e.g., "0.100.0+legacy")
  • Adds migration logic to convert existing string versions to semantic versions

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tigaserver_app/models.py Changes MobileApp.package_version to VersionField and updates Report.save() logic
tigaserver_app/migrations/0084_alter_mobileapp_package_version.py Migration to convert existing package versions to semantic format
tigaserver_app/tests/tests.py Updates test data to use semantic version format
api/views.py Converts semantic version back to integer for Report.package_version
api/tests/test_views.py Updates test expectations for version conversion
api/tests/integration/devices/create.tavern.yml Updates integration test data to use semantic versions
api/tests/integration/devices/update.tavern.yml Updates integration test data to use semantic versions
requirements/prod_20_04.pip Adds semantic-version dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.68%. Comparing base (e832408) to head (a47f345).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   50.68%   50.68%           
=======================================
  Files          72       72           
  Lines       10449    10452    +3     
=======================================
+ Hits         5296     5298    +2     
- Misses       5153     5154    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@epou epou merged commit 0101335 into master Aug 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants