Do not show carousel topBar if no images in report#642
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the report detail page to conditionally hide the carousel top bar when a report contains no images. The change prevents displaying an empty carousel area for reports without photos.
Key changes:
- Made the
topBarBackgroundBuildercallback return a nullableWidget?instead of non-nullableWidget - Added logic to
buildPhotoCarouselto returnnullwhenreport.photosis empty - Cached the result of
topBarBackgroundBuildercallback to avoid duplicate invocations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/pages/my_reports_pages/widgets/report_detail_page.dart | Updated to handle nullable top bar background and cache the callback result |
| lib/pages/my_reports_pages/detail/shared_report_widgets.dart | Modified buildPhotoCarousel to return null when no photos exist |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 25.45% 25.46% +0.01%
==========================================
Files 25 25
Lines 1662 1661 -1
==========================================
Hits 423 423
+ Misses 1239 1238 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.