Skip to content

Refactor buildLeadingImage#643

Merged
epou merged 1 commit intomainfrom
refactor_buildLeadingImage
Nov 13, 2025
Merged

Refactor buildLeadingImage#643
epou merged 1 commit intomainfrom
refactor_buildLeadingImage

Conversation

@epou
Copy link
Member

@epou epou commented Nov 13, 2025

No description provided.

@epou epou requested a review from Copilot November 13, 2025 08:49
@epou epou self-assigned this Nov 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the buildLeadingImage method to improve code maintainability by extracting common placeholder widget creation logic and introducing a constant for repeated size values.

Key Changes:

  • Extracted placeholder widget creation into a helper function to eliminate code duplication
  • Introduced a size constant to replace magic numbers for width/height values

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.52%. Comparing base (221e724) to head (337ebec).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...my_reports_pages/detail/shared_report_widgets.dart 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   25.45%   25.52%   +0.07%     
==========================================
  Files          25       25              
  Lines        1662     1657       -5     
==========================================
  Hits          423      423              
+ Misses       1239     1234       -5     
Flag Coverage Δ
unittests 25.52% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...my_reports_pages/detail/shared_report_widgets.dart 10.16% <0.00%> (+0.79%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epou epou added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit dbf91cd Nov 13, 2025
6 checks passed
@epou epou deleted the refactor_buildLeadingImage branch November 13, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants