Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the locale support checking mechanism in the localization delegate. Instead of maintaining a hardcoded list of supported language codes, the implementation now delegates to a centralized application.supportedLocales() method.
Key Changes:
- Replaced hardcoded list of 21 language codes with a call to
application.supportedLocales() - Added import for
Application.dartto access the centralized locale configuration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 25.75% 25.63% -0.12%
==========================================
Files 25 26 +1
Lines 1658 1693 +35
==========================================
+ Hits 427 434 +7
- Misses 1231 1259 +28
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.