Python 3.12 Compatibility Issue

[fdeguire03]

Summary

This PR updates the rsort field definitions in suite2p/detection/stats.py to replace mutable default values with default_factory. As of Python 3.12, dataclass enforces that default fields cannot be mutable type, so it is not currently possible to run suite2p in Python 3.12 or newer. Implementing this change ensures compatibility with Python 3.12 and prevents unintended shared state across instances.

Changes

Updated rsort in suite2p/detection/stats.py to use default_factory = lambda: np.sort(distance_kernel(radius=30).flatten()) instead of default=np.sort(distance_kernel(radius=30).flatten()).

Verified compatibility with Python 3.12, which now enforces stricter checks on mutable defaults. Also verified backward compatibility with Python 3.9. The default_factor parameter was introduced in Python 3.7 with the dataclasses module, so implementation of this pull request will not affect any previous versions of Python that are able to run suite2p.

Reasoning

Python 3.12 introduced a stricter enforcement of mutable defaults in dataclass fields, raising a ValueError when using a mutable default directly. This fix ensures proper instance-level initialization while maintaining the intended behavior.

Testing

Verified that the updated implementation runs correctly without ValueError in Python 3.12.