Skip to content

Restore default_ops in suite2p module?#1225

Open
StephenThornquist wants to merge 3 commits into
MouseLand:mainfrom
StephenThornquist:main
Open

Restore default_ops in suite2p module?#1225
StephenThornquist wants to merge 3 commits into
MouseLand:mainfrom
StephenThornquist:main

Conversation

@StephenThornquist
Copy link
Copy Markdown

One test (run_pipeline.py) and probably a lot of other-user code that has used suite2p programmatically use the default_ops function to populate settings (and then tweak args from there). From quickly looking at the more recent changes to the code, it looks like there's a migration to default_settings, which (as far as I can tell) contains the same info just derived from an internal dict with additional information for the GUI, presumably to keep it all in one place? I was curious if there's a reason not to make default_ops accessible the way it was before from suite2p import default_ops so that old code doesn't break when a user updates their suite2p? I get that it's dangerous to have two dicts floating around that might disagree on parameters, so I made default_ops() return {**_default_ops(), **default_settings()} so that default_settings always tracks the important variables.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.36%. Comparing base (be8830d) to head (2459ba1).
⚠️ Report is 228 commits behind head on main.

Files with missing lines Patch % Lines
suite2p/registration/register.py 50.00% 4 Missing ⚠️
suite2p/default_ops.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   55.21%   58.36%   +3.15%     
==========================================
  Files          43       47       +4     
  Lines        5055     4439     -616     
==========================================
- Hits         2791     2591     -200     
+ Misses       2264     1848     -416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant