Restore default_ops in suite2p module?#1225
Open
StephenThornquist wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
+ Coverage 55.21% 58.36% +3.15%
==========================================
Files 43 47 +4
Lines 5055 4439 -616
==========================================
- Hits 2791 2591 -200
+ Misses 2264 1848 -416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test (
run_pipeline.py) and probably a lot of other-user code that has usedsuite2pprogrammatically use thedefault_opsfunction to populate settings (and then tweak args from there). From quickly looking at the more recent changes to the code, it looks like there's a migration todefault_settings, which (as far as I can tell) contains the same info just derived from an internal dict with additional information for the GUI, presumably to keep it all in one place? I was curious if there's a reason not to makedefault_opsaccessible the way it was beforefrom suite2p import default_opsso that old code doesn't break when a user updates theirsuite2p? I get that it's dangerous to have two dicts floating around that might disagree on parameters, so I madedefault_ops()return{**_default_ops(), **default_settings()}so thatdefault_settingsalways tracks the important variables.