Add sync toggle and opposite-view ROI outline#1241
Open
SomeKindOfDuck wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small GUI improvement for manual ROI curation. I kept the change optional and tried to preserve the existing behavior when the sync toggle is disabled.
Summary
This PR improves manual ROI curation in the GUI by adding an optional sync toggle for the cell and not-cell views.
When enabled, panning and zooming in one ROI view updates the other view. The selected ROI is also shown as an outline in the opposite view, which makes it easier to compare corresponding cell and not-cell regions.
Changes
sync viewscheckbox near the ROI view controls.Tests
python -m compileall suite2p/guipytest -vsThe warnings appear to come from existing dependencies or unrelated non-GUI modules.
Manual checks