chore(gradle): build-logic; convention plugins; build file cleanup #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankoppier
requested changes
Nov 10, 2025
Collaborator
stefankoppier
left a comment
stefankoppier
left a comment
There was a problem hiding this comment.
Thanks for the PR!
| `maven-publish` | ||
| } | ||
|
|
||
| val javadocJar = tasks.named<Jar>("javadocJar") |
Collaborator
There was a problem hiding this comment.
Can javadocJar and emptyJar be inlined?
| import org.gradle.api.Project | ||
| import kotlin.math.max | ||
|
|
||
| internal fun Project.halfWorkerCount() = max(gradle.startParameter.maxWorkerCount, 1) |
Collaborator
There was a problem hiding this comment.
If I read the documentation correctly, gradle.startParameter.maxWorkerCount defaults to the number of processors (the same as the original API used), but that's not half ;)
|
|
||
| private fun Project.registerDocumentationArtifacts() { | ||
| val dokkaHtml = tasks.named("dokkaGeneratePublicationHtml", DokkaGeneratePublicationTask::class.java) | ||
| tasks.register("javadocJar", Jar::class.java) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| tasks.register("javadocJar", Jar::class.java) { | |
| tasks.register<Jar>("javadocJar") { |
| dependsOn(dokkaHtml) | ||
| } | ||
|
|
||
| tasks.register("emptyJar", Jar::class.java) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| tasks.register("emptyJar", Jar::class.java) { | |
| tasks.register<Jar>("emptyJar") { |
| } | ||
|
|
||
| private fun Project.configureTests() { | ||
| tasks.withType(Test::class.java).configureEach { |
Collaborator
There was a problem hiding this comment.
Suggested change
| tasks.withType(Test::class.java).configureEach { | |
| tasks.withType<Test>().configureEach { |
| # Gradle properties are not passed to included builds https://github.com/gradle/gradle/issues/2534 | ||
| org.gradle.parallel=true | ||
| org.gradle.caching=true | ||
| org.gradle.configureondemand=true |
Collaborator
There was a problem hiding this comment.
Cool! I didn't know about org.gradle.configureondemand yet.
| `maven-publish` | ||
| } | ||
|
|
||
| val javadocJar = tasks.named<Jar>("javadocJar") |
Collaborator
There was a problem hiding this comment.
Can these be inlined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle stuff