Fix camera2D flipping textures #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranoke
reviewed
Aug 18, 2021
| @@ -1571,6 +1574,14 @@ void gs_graphics_submit_command_buffer(gs_command_buffer_t* cb) | |||
| // Switch on uniform type to upload data | |||
| switch (u->type) | |||
| { | |||
|
|
|||
| case GSGL_UNIFORMTYPE_BOOL: //GSGL size of bool is uint32, which is fine for a normally one byte bool in C | |||
There was a problem hiding this comment.
Will it be ok if someone will try to compile it using c++ compiller?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In regards to issue #29, here is a proposed fix.
Screen coordinates is quite nice !
Keep up the good work