Implement workflow inspection command #121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `reqwest` library is async by defalt, but we used the blocking module to make blocking calls. However, the blocking module is just a thin wrapper on the async one. This means that we copile (and use) the Tokio framework for nothing. I replaced the `reqwest` dependency with the much more lightweight `ureq` library. This gets rid of ~20 dependencies and cuts down compile times, from about ~70 seconds to ~50 (-28%).
This is similar in scope to the - now deprecated - kerblam run --desc option. It paves the way to the features described in #120
MrHedmad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #120.
TODO
Before merging, tick all of these boxes:
cargo test -- --include-ignoredpasses without errors or warnings.CHANGELOG.mdhas been updated to reflect these changes.