-
-
Notifications
You must be signed in to change notification settings - Fork 205
✨ Introduce Scribe Logging package #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Loop/Settings Window/Settings/Behavior/BehaviorConfiguration.swift
Outdated
Show resolved
Hide resolved
Loop/Settings Window/Settings/Keybindings/Item View/KeybindItemView.swift
Outdated
Show resolved
Hide resolved
Loop/Settings Window/Settings/Keybindings/Keybind Recorder/Keycorder.swift
Outdated
Show resolved
Hide resolved
Loop/Settings Window/Settings/Keybindings/Keybind Recorder/TriggerKeycorder.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces Scribe, a unified logging package that standardizes application logging across Loop by replacing ad-hoc print statements and direct os_log calls with a centralized logging API.
- Adds Scribe as a Swift package dependency tracking the main branch
- Defines 20+ centralized logging categories in
Logger+Extensions.swift - Migrates 13+ files from OSLog's
Loggerto Scribe'sLogAPI
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Loop.xcodeproj/project.pbxproj | Adds Scribe package dependency configured to track main branch |
| Loop/Extensions/Logger+Extensions.swift | Defines centralized LogCategory extensions for all logging contexts |
| Loop/App/AppDelegate.swift | Configures Scribe logging with minimum info level and migrates URL handling logs |
| Loop/App/AppDelegate+UNNotifications.swift | Migrates notification-related logging to Scribe |
| Loop/App/DataPatcher.swift | Migrates data migration logging to Scribe |
| Loop/Core/LoopManager.swift | Migrates core window management logging to Scribe |
| Loop/Core/URLCommandHandler.swift | Migrates URL command handling logs from debug to info level |
| Loop/Core/WindowDragManager.swift | Migrates window dragging event logging to Scribe |
| Loop/Core/Observers/MouseInteractionObserver.swift | Migrates mouse interaction logging to Scribe |
| Loop/Icon/IconManager.swift | Migrates app icon management logging to Scribe |
| Loop/Migration/Migrator.swift | Migrates keybind import logging to Scribe |
| Loop/Stashing/StashManager.swift | Migrates window stashing operation logging to Scribe |
| Loop/Stashing/StashedWindow.swift | Migrates stashed window frame logging to Scribe |
| Loop/Stashing/StashedWindowStore.swift | Migrates window store persistence logging to Scribe |
| Loop/Updater/Updater.swift | Migrates app update process logging to Scribe |
| Loop/Utilities/AccessibilityManager.swift | Adds compatibility comments for macOS 26.0 API usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86d2d96 to
8b4a3e9
Compare
# Conflicts: # Loop.xcodeproj/project.pbxproj # Loop/Settings Window/Settings/Keybinds/Keybind Recorder/TriggerKeycorder.swift # Loop/Settings Window/SettingsWindowManager.swift
8b4a3e9 to
1223d51
Compare
Introduce a unified logging package, Scribe, to standardise and simplify application logging.
Usage
Notes
printstatements and directos_logcalls.