New mask mode combining Ignore and Segment [Volinga]#1314
Merged
Conversation
MrNeRF
approved these changes
Jun 18, 2026
MrNeRF
left a comment
Owner
There was a problem hiding this comment.
We verified and tested. Code looks also solid. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have found ourselves in the need of an extra masking mode that combines both the segment (e.g. for the sky) and ignore (for specific components of the scene) in a single training.
An attempt to add this mode is proposed in this PR, called
SegmentAndIgnore. One caveat is that this mode does not permit a user configurable threshold since the masks are expected to be single files and are split in 3 bands. Each band is made big enough so JPEG compression won't scramble them together. We went through the single file approach since it seemed to be a much faster implementation.Below there is an example of the same 10K training.