BUILD_TESTS=ON on CI#685
Conversation
|
hmm no space left on device ... why didn't we encounter this issue before when libtorch was a required dependency? |
|
Right, forgot. That was a problem on linux builds before. It ocassionally failed running out space. All of it could be freed from libtorch. However, it is convenient to make sure the tensor implementation works correctly. |
|
just letting you know - on my windows desktop, I got int /size_t casting errors from Tensor::from_vector when i try to build tests. |
|
Run out of space in linux CI, and failed on windows CI because we have one single test exe for all GPU and non GPU tests and we are running the test exe on Windows CI. @dozeri83 the problem you described should be fixed in the latest master |
|
Ok, I am not sure how feasible building the tests in the limited CI pipeline is? Wdyt? |
|
@MrNeRF how about splitting the test exe into 2, one GPU and one non GPU? At least we can still compile all the tests on windows CI and only run the non GPU unicode tests like usual. |
|
@miriameng Not sure what value that brings. Building would be some value but then again it has libtorch issues. Pretty much everything critical runs on GPU. I would like to run the evals for every pr that touches the training to make sure that that it is not broken. Apparently, this is not doable with github. I will try to get an infrastructure sponsor over the next months which will hopefully get us a better build node. I think we should postpone this until I have something. |
resolve #677