Skip to content

BUILD_TESTS=ON on CI#685

Draft
miriameng wants to merge 2 commits into
MrNeRF:masterfrom
miriameng:ci_build_tests
Draft

BUILD_TESTS=ON on CI#685
miriameng wants to merge 2 commits into
MrNeRF:masterfrom
miriameng:ci_build_tests

Conversation

@miriameng
Copy link
Copy Markdown
Collaborator

resolve #677

@miriameng miriameng requested a review from MrNeRF January 3, 2026 06:50
@miriameng
Copy link
Copy Markdown
Collaborator Author

hmm no space left on device ... why didn't we encounter this issue before when libtorch was a required dependency?

@MrNeRF
Copy link
Copy Markdown
Owner

MrNeRF commented Jan 3, 2026

Right, forgot. That was a problem on linux builds before. It ocassionally failed running out space.

All of it could be freed from libtorch. However, it is convenient to make sure the tensor implementation works correctly.

@dozeri83
Copy link
Copy Markdown
Collaborator

dozeri83 commented Jan 3, 2026

just letting you know - on my windows desktop, I got int /size_t casting errors from Tensor::from_vector when i try to build tests.
After fixing them, i got load dll error code from lichtfeld_tests.exe ...

@miriameng
Copy link
Copy Markdown
Collaborator Author

Run out of space in linux CI, and failed on windows CI because we have one single test exe for all GPU and non GPU tests and we are running the test exe on Windows CI.

@dozeri83 the problem you described should be fixed in the latest master

@MrNeRF
Copy link
Copy Markdown
Owner

MrNeRF commented Jan 3, 2026

Ok, I am not sure how feasible building the tests in the limited CI pipeline is? Wdyt?
There are some separate unicode tests that only run on windows.

@miriameng
Copy link
Copy Markdown
Collaborator Author

miriameng commented Jan 3, 2026

@MrNeRF how about splitting the test exe into 2, one GPU and one non GPU? At least we can still compile all the tests on windows CI and only run the non GPU unicode tests like usual.

@MrNeRF
Copy link
Copy Markdown
Owner

MrNeRF commented Jan 3, 2026

@miriameng Not sure what value that brings. Building would be some value but then again it has libtorch issues. Pretty much everything critical runs on GPU. I would like to run the evals for every pr that touches the training to make sure that that it is not broken. Apparently, this is not doable with github. I will try to get an infrastructure sponsor over the next months which will hopefully get us a better build node. I think we should postpone this until I have something.

@miriameng miriameng marked this pull request as draft January 5, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUILD_TESTS=ON in CI?

3 participants