Skip to content

specify current working directory explicitly when executing shell commands #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

specify current working directory explicitly when executing shell commands #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/MrRio/ShellWrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,13 @@ private static function __run($arguments)
2 => array('pipe', 'w') // Stderr
);

$process = proc_open($shell, $descriptor_spec, $pipes);
// If you use function chdir() to change working directory to a different directory first, following two
// statements should still return same directories. However, in Travis CI they return different directories back
// (the 2nd one returns the directory where the PHP script was invoked).
// 1. getcwd()
// 2. (string) ShellWrap::pwd()
// Thus we have the 4th parameter (getcwd()) specified explicitly here, also ideally it's unnecessary.
$process = proc_open($shell, $descriptor_spec, $pipes, getcwd());

if (is_resource($process)) {

Expand Down