feat: change zod schema for form validation in local persistence#11
feat: change zod schema for form validation in local persistence#11csantosr wants to merge 1 commit intoMrRoiz:mainfrom
Conversation
| }, | ||
| ); | ||
|
|
||
| const LocalGameFormSchema = z.object({ |
There was a problem hiding this comment.
Is this necessary? Maybe I'm wrong but doesnt the watch method return the right type of the form already?
There was a problem hiding this comment.
It is. The watch return it as Partial. Meaning that each value can be undefined
There was a problem hiding this comment.
Then we can try add default values there instead of creating a new zod schema, or create a wrapper atom, that handles those undefined values
| } | ||
| if (gameSettings.players.length >= MIN_PLAYERS) { | ||
| hasHydrated.current = true; | ||
| form.reset(gameSettings); |
There was a problem hiding this comment.
Instead of doing this what if we directly pass that value to the default values of the form?
There was a problem hiding this comment.
its a hydration timing problem. The first value that the atom takes when the component is mounted is the default value and then the localStorage is loaded. Meanwhile, useForm initializes on mount, having the empty default as its default values.
csantosr
force-pushed
the
feature/persistence
branch
from
aaa71ac to
141d745
Compare
csantosr
force-pushed
the
feature/persistence
branch
from
141d745 to
c1265e1
Compare
|
Implemented tanstack form instead |
2 participants
New zod schema changing the
.minand the.nonempty