-
Notifications
You must be signed in to change notification settings - Fork 1
chore: add precommit and pr action #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Check PR | ||
|
|
||
| on: [pull_request] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| check-code: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: "Setup yarn" | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "22" | ||
| cache: "yarn" | ||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| - name: Biome check | ||
| run: yarn link | ||
| - name: Typescript check | ||
| run: yarn type-check | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| yarn lint | ||
| yarn type-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| import 'server-only' | ||
| import 'server-only'; | ||
|
|
||
| const dictionaries = { | ||
| en: () => import('../../dictionaries/en.json').then((module) => module.default), | ||
| es: () => import('../../dictionaries/es.json').then((module) => module.default), | ||
| } | ||
| en: () => | ||
| import('../../dictionaries/en.json').then((module) => module.default), | ||
| es: () => | ||
| import('../../dictionaries/es.json').then((module) => module.default), | ||
| }; | ||
|
|
||
| export type Locale = keyof typeof dictionaries | ||
| export type Locale = keyof typeof dictionaries; | ||
|
|
||
| export const hasLocale = (locale: string): locale is Locale => | ||
| locale in dictionaries | ||
| locale in dictionaries; | ||
|
|
||
| export const getDictionary = async (locale: Locale) => dictionaries[locale]() | ||
| export const getDictionary = async (locale: Locale) => dictionaries[locale](); | ||
|
|
||
| export type Dictionary = Awaited<ReturnType<typeof getDictionary>>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| import { atom } from "jotai"; | ||
| import type z from "zod"; | ||
| import type { localGameFormSchema } from "../setup/_components/form"; | ||
| import { atom } from 'jotai'; | ||
| import type z from 'zod'; | ||
| import type { localGameFormSchema } from '../setup/_components/form'; | ||
|
|
||
| export const gameSettingsAtom = atom<z.infer<typeof localGameFormSchema>>({ | ||
| players: [], | ||
| numberOfSpies: "0", | ||
| numberOfSpies: '0', | ||
| randomNumberOfSpies: false, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command 'yarn link' appears to be incorrect. This command is used to create symlinks for local package development, not to run linting checks. Based on the context and the pre-commit hook, this should be 'yarn lint' to run the Biome linter check.