feat: persistency on game settings & clear button#9
Merged
MrRoiz merged 1 commit intoMrRoiz:mainfrom Jan 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements persistent game settings using Jotai's atomWithStorage to save form data to localStorage, and adds a "Clear" button to reset settings. This addresses issue #6 where game settings were lost on page reload.
Changes:
- Converted
gameSettingsAtomfrom a regular atom toatomWithStoragefor localStorage persistence - Added hydration logic to load saved settings from storage into the form on mount
- Added a "Clear" button with translations in English and Spanish to reset settings to defaults
- Implemented auto-save functionality that persists form changes to storage as the user types
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| app/[lang]/game/_store/game-settings.ts | Changed from regular atom to atomWithStorage for localStorage persistence |
| app/[lang]/game/local/setup/_components/form.tsx | Added hydration logic, auto-save effect, clear button, and extracted default values to a constant |
| dictionaries/en.json | Added "clear" translation for the clear button |
| dictionaries/es.json | Added "clear" translation ("Limpiar") for the clear button |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a3e47d4 to
f48fb53
Compare
Collaborator
Author
|
@MrRoiz this PR is ready for your review 🫶 |
MrRoiz
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6
Note: the load of the storage values into the form looks like an overkill, more knowing that values exist. But it being an atom that we are updating on every change, it create weird behaviors like the input constantly unfocusing