feat(validation): add between validators#221
Open
jamie94bc wants to merge 2 commits intoMrWolfZ:masterfrom
Open
feat(validation): add between validators#221jamie94bc wants to merge 2 commits intoMrWolfZ:masterfrom
jamie94bc wants to merge 2 commits intoMrWolfZ:masterfrom
Conversation
Owner
|
Thank you @jamie94bc for this contribution. The code looks good. The only thing missing is an update to the validation docs (at |
Author
|
Done! |
Author
dzonatan
approved these changes
Feb 24, 2021
Contributor
|
A bit late answer but I have no access for merging. Pinging @MrWolfZ |
|
This would be useful, I was just looking for this. Specifically, the advantage is to be able to indicate in the error message "This must be between x & y". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inclusive and exclusive between validators as a shorthand for combining the
lessThan,greaterThanetc. validators and facilitating better error messages.