One-click shortcuts to launch instances#145
Merged
Conversation
launching headlessly
- Add UI button to export shortcut to file and generate Exec field - Add account selection to shortcuts - Split shortcut menu view into separate module - Make `self.account_selected` no longer an Option
osascript instead
keeping list of every shortcut file
Owner
Author
|
btw for anyone reading this, dw I'm not relying on AI slop to code, i'm just making it check my work as a last-minute thing |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 32 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
quantum_launcher/src/cli/mod.rs:213
- If
file_utils::get_launcher_dir()failed earlier (is_dir_err == true), this exits even when--diris provided (and you already setQLDIR+launcher_dirabove). That makes--dirunable to recover from a bad/missing default dir. Consider skipping the early-exit whencli.dir.is_some()(or recomputingis_dir_errafter applying--dir).
if let Some(p) = &cli.dir {
*launcher_dir = Some(p.clone());
std::env::set_var("QLDIR", p);
}
if let Some(subcommand) = cli.command {
if is_dir_err {
std::process::exit(1);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 47 out of 49 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create shortcuts for instances, that you can then use to launch the game without opening the launcher.
.desktop).lnk).app).appbundle generation + metadata + xattr stuffqldirand other edge cases