Skip to content

Dev modrinth.export#199

Draft
void90user wants to merge 176 commits into
Mrmayman:instance-import-exportfrom
void90user:dev-Modrinth.Export
Draft

Dev modrinth.export#199
void90user wants to merge 176 commits into
Mrmayman:instance-import-exportfrom
void90user:dev-Modrinth.Export

Conversation

@void90user

Copy link
Copy Markdown
Contributor

No description provided.

@Mrmayman

Copy link
Copy Markdown
Owner

hmm it seems the async-zip library you added depends on something that needs nightly version of rust

image
image

@void90user

Copy link
Copy Markdown
Contributor Author

what should we do then?

@Mrmayman

Copy link
Copy Markdown
Owner

ok fixed that. Btw what is qlmp file? is it quantumlauncher specific or something else? because we already have qmp

@void90user

Copy link
Copy Markdown
Contributor Author

its a modpack format i made for QL, if you wanna we can look at the exsisting one too and choose which is best

@Mrmayman

Copy link
Copy Markdown
Owner

i think better to extend the existing qmp format tbh. Anyway i'm soon extending it with instance exporting. What are the extra features in the new one we could add to qmp?

@void90user

Copy link
Copy Markdown
Contributor Author

could you send the format structure on dc?

@void90user

Copy link
Copy Markdown
Contributor Author

looked at yours, isnt mine a bit simpler?

@void90user

Copy link
Copy Markdown
Contributor Author

@Mrmayman

@void90user

Copy link
Copy Markdown
Contributor Author

also curseforge still needs file ids i dont know how to get
and you might wanna do somthing about the panic when unsupported loader is found

- Add peek method to QMP presets

- Major refactor to use Arc<str> in many places

- Merge PackError with ModError

- Other tweaks
@Mrmayman

Copy link
Copy Markdown
Owner

looked at yours, isnt mine a bit simpler?

i mean, these two were made for different things. Mine was made for local sharing between friends in group chats and stuff. Yours was made for publishing. Anyway we can just merge functionality

there's also the matter of backwards compat, i know some ppl using the old format.

In my opinion it's better to extend the original qmp. I added some missing features to qmp, all that's left is file hashes, also the independent files (instead of list of mods/resource packs/... projects). Do you need that, or is a mix of overrides/ and projects (mods, resource packs, etc) enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants