[+] 高仿旧框下一曲目随机图片提示功能 by WUGqnwvMQPzl · Pull Request #111 · MuNET-OSS/AquaMai

WUGqnwvMQPzl · 2026-01-24T17:53:16Z

No description provided.

gemini-code-assist · 2026-01-24T17:53:21Z

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

WUGqnwvMQPzl · 2026-01-24T17:58:33Z

fuck github.

WUGqnwvMQPzl · 2026-01-24T18:00:37Z

come the fuck on wtf github?

gemini-code-assist · 2026-01-24T18:01:52Z

你好 @WUGqnwvMQPzl，看起来你可能想使用 Gemini Code Assist 的某个命令。请注意，/gemini 需要后跟一个具体的命令才能执行操作。

你可以尝试以下命令：

/gemini review: 对当前拉取请求进行代码审查。
/gemini summary: 提供当前拉取请求的摘要。
@gemini-code-assist: 当被明确标记时，我会在评论中回复。

如果你想让我审查代码，请使用 /gemini review。

WUGqnwvMQPzl · 2026-01-24T18:02:19Z

@gemini-code-assist

gemini-code-assist · 2026-01-24T18:02:27Z

你好 @WUGqnwvMQPzl，你标记了我，但没有提供具体的命令。如果你想让我执行某个操作，请使用 /gemini <command> 或 @gemini-code-assist <command> 的格式。

你可以尝试以下命令：

/gemini review: 对当前拉取请求进行代码审查。
/gemini summary: 提供当前拉取请求的摘要。

如果你想让我审查代码，请使用 /gemini review。

WUGqnwvMQPzl · 2026-01-24T18:02:56Z

/gemini review

gemini-code-assist

Code Review

这个 PR 增加了一个新功能，在下一首曲目开始前显示一张随机提示图片，以模仿旧版游戏的体验。实现方式是使用 Harmony 来 patch 游戏逻辑，这对于这类 mod 来说是合适的。代码整体结构良好，但在正确性、性能和可维护性方面有几个可以改进的地方。

发现的主要问题包括：

随机数生成中存在一个 bug，导致其中一个语音提示永远不会被播放。
存在性能问题，游戏资源在频繁调用的方法中被重复加载，而不是被缓存起来。
针对两个不同游戏进程的 patch 之间存在大量重复代码。
一些硬编码的数值和数组大小使得代码不够健壮，也更难维护。
代码中存在不专业的注释，应该用更具说明性的注释代替。

我已经为以上每一点提供了具体的建议。解决这些问题将使代码更正确、性能更好、更易于维护。

gemini-code-assist · 2026-01-24T18:04:27Z

+    {
+        if (CheckNextTrackProcess(____mode) && !_timeCounterChanged)
+        {
+            ____timeCounter = 5f;


数值 5f 是一个“魔术数字”。它代表提示图片显示的时长。最好在类的顶部将其定义为一个命名的常量，以提高可读性并使其更易于修改。

建议在类顶部添加一个常量：
private const float TipDisplayDuration = 5f;
然后在这里使用它。

____timeCounter = TipDisplayDuration;

gemini-code-assist · 2026-01-24T18:04:27Z

+    [HarmonyPatch(typeof(KaleidxScopeFadeProcess), "OnStart")]
+    public static void KS_OnStart_Postfix(ProcessBase ___toProcess, List<KaleidxScopeFadeController> ___mainControllerList)
+    {
+        if (___toProcess.GetType() != typeof(MusicSelectProcess) || GameManager.MusicTrackNumber < 2)  // WTF SBGA???


像 WTF SBGA??? 这样的注释是不专业的，对未来的维护者没有帮助。最好解释一下为什么这个检查是必要的。例如，描述这段代码是为了解决哪个特定的游戏行为或问题。这个问题在第 204 和 217 行也存在。

WUGqnwvMQPzl · 2026-01-24T18:09:05Z

bugbot run

cursor · 2026-01-24T18:09:08Z

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

Co-authored-by: 凌莞~(=^▽^=) <opensource@c5y.moe>

cubic-dev-ai

2 issues found across 1 file

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="AquaMai.Mods/Fancy/NextTrackTips.cs">

<violation number="1" location="AquaMai.Mods/Fancy/NextTrackTips.cs:197">
P2: The window-creation, sound-effect, and voice-line logic is duplicated almost verbatim between `OnStart_Postfix` and `KS_OnStart_Postfix`. This duplication has already caused a subtle divergence (the off-by-one in the final-track voice check). Consider extracting the shared per-player setup into a helper method.</violation>

<violation number="2" location="AquaMai.Mods/Fancy/NextTrackTips.cs:218">
P2: Inconsistent last-track voice condition: `OnStart_Postfix` uses `MusicTrackNumber + 1U == GetMaxTrackCount()` while this KaleidxScopeFade counterpart uses `MusicTrackNumber == GetMaxTrackCount()`. One of these conditions is off-by-one, causing the final-track voice cue to play at the wrong time in one of the two code paths.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

cubic-dev-ai · 2026-04-04T09:58:52Z

+    [EnableGameVersion(25000, noWarn: true)]
+    [HarmonyPostfix]
+    [HarmonyPatch(typeof(KaleidxScopeFadeProcess), "OnStart")]
+    public static void KS_OnStart_Postfix(ProcessBase ___toProcess, List<KaleidxScopeFadeController> ___mainControllerList)


P2: The window-creation, sound-effect, and voice-line logic is duplicated almost verbatim between OnStart_Postfix and KS_OnStart_Postfix. This duplication has already caused a subtle divergence (the off-by-one in the final-track voice check). Consider extracting the shared per-player setup into a helper method.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At AquaMai.Mods/Fancy/NextTrackTips.cs, line 197: <comment>The window-creation, sound-effect, and voice-line logic is duplicated almost verbatim between `OnStart_Postfix` and `KS_OnStart_Postfix`. This duplication has already caused a subtle divergence (the off-by-one in the final-track voice check). Consider extracting the shared per-player setup into a helper method.</comment> <file context> @@ -0,0 +1,257 @@ + [EnableGameVersion(25000, noWarn: true)] + [HarmonyPostfix] + [HarmonyPatch(typeof(KaleidxScopeFadeProcess), "OnStart")] + public static void KS_OnStart_Postfix(ProcessBase ___toProcess, List<KaleidxScopeFadeController> ___mainControllerList) + { + if (___toProcess.GetType() != typeof(MusicSelectProcess) || GameManager.MusicTrackNumber < 2) // WTF SBGA??? </file context>

cubic-dev-ai · 2026-04-04T09:58:52Z

+
+            Mai2.Voice_Partner_000001.Cue nextTrackVoice = UnityEngine.Random.Range(0, 2) == 0 ? Mai2.Voice_Partner_000001.Cue.VO_000151 : Mai2.Voice_Partner_000001.Cue.VO_000152;
+            // WTF SBGA??
+            if (GameManager.MusicTrackNumber == GameManager.GetMaxTrackCount())


P2: Inconsistent last-track voice condition: OnStart_Postfix uses MusicTrackNumber + 1U == GetMaxTrackCount() while this KaleidxScopeFade counterpart uses MusicTrackNumber == GetMaxTrackCount(). One of these conditions is off-by-one, causing the final-track voice cue to play at the wrong time in one of the two code paths.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At AquaMai.Mods/Fancy/NextTrackTips.cs, line 218: <comment>Inconsistent last-track voice condition: `OnStart_Postfix` uses `MusicTrackNumber + 1U == GetMaxTrackCount()` while this KaleidxScopeFade counterpart uses `MusicTrackNumber == GetMaxTrackCount()`. One of these conditions is off-by-one, causing the final-track voice cue to play at the wrong time in one of the two code paths.</comment> <file context> @@ -0,0 +1,257 @@ + + Mai2.Voice_Partner_000001.Cue nextTrackVoice = UnityEngine.Random.Range(0, 2) == 0 ? Mai2.Voice_Partner_000001.Cue.VO_000151 : Mai2.Voice_Partner_000001.Cue.VO_000152; + // WTF SBGA?? + if (GameManager.MusicTrackNumber == GameManager.GetMaxTrackCount()) + nextTrackVoice = Mai2.Voice_Partner_000001.Cue.VO_000153; + SoundManager.PlayPartnerVoice(nextTrackVoice, i); </file context>

clansty · 2026-04-04T10:14:25Z


    #region KaleidxScopeFadeProcess Patch
-    [EnableGameVersion(25000, noWarn: true)]
+    [EnableGameVersion(25000, 26499, noWarn: true)]


据我所知，这里的内容大概会在这个类加载的时候被 jit 解析，让我验证一下这么写到底会不会有问题

[+] NextTrackTips

de2037e

[F] GitHub says: "We're confused", turns out the file encoding is a mess

4b4c6ef

WUGqnwvMQPzl closed this Jan 24, 2026

WUGqnwvMQPzl reopened this Jan 24, 2026

gemini-code-assist Bot reviewed Jan 24, 2026

View reviewed changes

WUGqnwvMQPzl and others added 3 commits January 25, 2026 21:27

[F] Fix random voice line

8585efb

[O] config field fix

55bc7b5

Apply suggestions from code review

4fbd829

Co-authored-by: 凌莞~(=^▽^=) <opensource@c5y.moe>

cubic-dev-ai Bot reviewed Apr 4, 2026

View reviewed changes

[O] add maxGameVersion on kld patches

38ea467

clansty reviewed Apr 4, 2026

View reviewed changes

Merge branch 'main' into finale-next-track

1d91b39

Conversation

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

gemini-code-assist Bot commented Jan 24, 2026

Uh oh!

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

gemini-code-assist Bot commented Jan 24, 2026

Uh oh!

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

gemini-code-assist Bot commented Jan 24, 2026

Uh oh!

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

WUGqnwvMQPzl commented Jan 24, 2026

Uh oh!

cursor Bot commented Jan 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WUGqnwvMQPzl Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

clansty Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cubic-dev-ai Bot Apr 4, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 4, 2026 •

edited

Loading