Check that report files are unchanged (for now in streamlit)#132
Merged
Check that report files are unchanged (for now in streamlit)#132
Conversation
Collaborator
enryH
commented
Jun 20, 2025
- check against document files, not only that the report can be generated
- using git diff to do that
- changes will need sometimes explicit updates of the report files
translated to run `isort --check-only --diff src`
Collaborator
Author
|
Ok, first draft for a streamlit report.
|
sayalaruano
approved these changes
Jun 20, 2025
Collaborator
|
Collaborator
Author
|
cool. I will merge and then we can do the changes on the other PRs related to streamlit. I will create a new PR to do the same checks for |
Collaborator
|
You meant creating one qmd file per report type, or something else? |
Collaborator
Author
|
Yes one qmd file per report, maybe with a specified suffix. Then they could all live in one folder. but I will start with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.