Load home image on the base folder when creating a report from a directory#152
Merged
sayalaruano merged 6 commits intomainfrom Jul 18, 2025
Merged
Load home image on the base folder when creating a report from a directory#152sayalaruano merged 6 commits intomainfrom
sayalaruano merged 6 commits intomainfrom
Conversation
… exist when creating a report from a directory A Enum for ImageFormats was also created on the report.py script
sayalaruano
changed the title
sayalaruano
changed the title
sayalaruano
changed the title
enryH
reviewed
Jul 18, 2025
| Path to the 'home_image' image file as a string if found, otherwise an | ||
| empty string. | ||
| """ | ||
| for image_format in r.ImageFormat: |
Collaborator
There was a problem hiding this comment.
so this will return the first one.
Collaborator
Author
There was a problem hiding this comment.
Hmm, but an Enum is iterable, isn't it? So, inside a for-loop should return all the components, or not?
Collaborator
There was a problem hiding this comment.
Sorry, I should got this wrong. So the file will need to called home_image.jpg or alike?
Collaborator
Author
There was a problem hiding this comment.
Yes, exactly, bc if we allow any image, it will also add it into the default section created for components at the section level
enryH
approved these changes
Jul 18, 2025
Collaborator
enryH
left a comment
enryH
left a comment
There was a problem hiding this comment.
I am not sure what exactly happens if there are two version of the same image, but let's say it's a detail for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion on #146, I added code to look for a home image in the base folder and load it if exist, when creating a report from a directory.
A Enum for ImageFormats was also created in the report.py script