Skip to content

Add EventEmittingTween tag to event tweens #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rabbival wants to merge 7 commits into from
Closed

Add EventEmittingTween tag to event tweens #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22778a3
add EventEmittingTween tag to event tweens
Rabbival Dec 25, 2025
3bba016
bump version and add documentation
Rabbival Dec 28, 2025
cb4c794
make EventEmittingTween a required component instead of manually atta…
Rabbival Jan 1, 2026
9e2e9e5
add EventEmittingTween tag to event tweens
Rabbival Dec 25, 2025
40901b7
Merge branch 'event_emitting_tween_tag' of https://github.com/Multiri…
Rabbival Jan 1, 2026
b9f62da
fix changelog as per request
Rabbival Jan 1, 2026
6df396e
Bump the minor version instead of patch
Rabbival Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## Unreleased - XXXX-XX-XX

@Multirious Multirious Jan 1, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing Unreleased - XXXX-XX-XX into a specific date and version is only allowed within release PR. Also, where's the changlong for v0.10.0? What did we do then?

@Rabbival Rabbival Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All we did for 0.10 was update to Bevy 0.17
I'll make a patch commit


- Migrate to Bevy 0.17.2

@Multirious Multirious Jan 1, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that bumping patch version does nothing when we don't need it. If for some reason, a user must use a specific bevy version older than this for some reason, this can cause incompatibility for no gain, but it's probably a non-issue for bevy project. Also, this should be done in a separate PR.

- Add `EventEmittingTween` tag to event emitting tweens, for ease of querying no matter their data type

## v0.10.0 - 2025-10-08

- Migrate to Bevy 0.17

## v0.9.1 - 2025-07-15

Expand Down
12 changes: 6 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "bevy_tween"
description = "Flexible tweening plugin library for Bevy"
version = "0.10.0"

@Multirious Multirious Jan 1, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be done within a release PR. Also, why are we updating patch version?

@Rabbival Rabbival Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to release a new version of the helpers crate (since crates have to be built upon stable crate versions, can't just route it to main)

@Multirious Multirious Jan 1, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch version is used for bug fixes. This is unrelated to releasing the crate.

@Rabbival Rabbival Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we release an entirely new version for two lines of code?
Sounds absurd

@Multirious Multirious Jan 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's how semver works. You can read the semver specification on why we need to increment the minor version. Also, releasing it as patch is still an entirely new version. Semver is used to state project compatibility and how the downstream users should deal with them.

It will be very surprising for user of our crate to notice that, an entirely new component, is being inserted into their runtime from just updating their crate to the newer patch version.

Semver DOES NOT implies how big of a changes a crate has made between major, minor, and patches. (even though the major version seems to be used for marketing nowadays...) There could be thousand line of bug fixes and that can still be within patch version.

@Rabbival Rabbival Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, done

@Multirious Multirious Jan 1, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, not yet. Bumping crate version should also be done in a separated PR. The same withing updating Unreleased - XXXX-XX-XX changelog.

version = "0.11.0"
edition = "2024"
authors = ["Multirious", "Rabbival"]
license = "MIT OR Apache-2.0"
Expand All @@ -18,12 +18,12 @@ resolver = "2"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies.bevy]
version = "0.17.2"
version = "0.17.3"
default-features = false
features = ["std"]

[dependencies.bevy_math]
version = "0.17.2"
version = "0.17.3"
default-features = false
features = ["curve"]

Expand All @@ -41,14 +41,14 @@ features = ["std"]

[dependencies.bevy_lookup_curve ]
version = "0.10.0"
optional = true
optional = true

[dev-dependencies]
bevy-inspector-egui = "0.34.0"
rand = "0.9.1"

[dev-dependencies.bevy]
version = "0.17.2"
version = "0.17.3"
default-features = false
features = [
"bevy_window",
Expand All @@ -60,7 +60,7 @@ features = [
"png",
"bevy_sprite_render",
"bevy_post_process"
]
]

[build-dependencies]
rustc_version = "0.4.1"
Expand Down
6 changes: 6 additions & 0 deletions src/tween_event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,16 @@ impl PluginGroup for DefaultTweenEventPlugins {
/// Fires [`TweenEvent`] whenever [`TimeSpanProgress`] and [`TweenEventData`] exist in the same entity.
#[derive(Default, Debug, Clone, PartialEq, Eq, Hash, Component, Reflect)]
#[reflect(Component)]
#[require(EventEmittingTween)]
pub struct TweenEventData<Data = ()>(pub Data)
where
Data: Send + Sync + 'static;

/// Used to mark event-emitting tweens (tweens with `TweenEventData<Data>` for some registered `Data`)
#[derive(Default, Debug, Clone, PartialEq, Eq, Hash, Component, Reflect)]
#[reflect(Component)]
pub struct EventEmittingTween;

impl<Data: Send + Sync + 'static> TweenEventData<Data> {
/// Create new [`TweenEventData`] with custom user data.
pub fn with_data(data: Data) -> Self {
Expand Down
Loading