Skip to content

Add rich styling, box layout, and CSS-inspired gradient support#211

Merged
MuntasirSZN merged 9 commits into
mainfrom
copilot/add-hsl-rgb-support-and-box-layout
May 19, 2026
Merged

Add rich styling, box layout, and CSS-inspired gradient support#211
MuntasirSZN merged 9 commits into
mainfrom
copilot/add-hsl-rgb-support-and-box-layout

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

  • Review new feedback about named colors and config schema generation
  • Inspect current config schema generation, config types, and named-color parsing
  • Switch named-color parsing to cssparser-color
  • Replace config.schema.toml with schemars-generated JSON schema in the config directory
  • Update docs and any generation/build hooks for the new schema flow
  • Run targeted tests, then full fmt/clippy/build/test validation
  • Reply to the new PR feedback with the addressing commit hash

Copilot AI and others added 5 commits May 19, 2026 02:40
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/d3554e08-2490-4fff-9aa7-8a6f050a997d

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/d3554e08-2490-4fff-9aa7-8a6f050a997d

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/d3554e08-2490-4fff-9aa7-8a6f050a997d

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/9ac120db-2294-4914-b0b0-34431deaa605

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/9ac120db-2294-4914-b0b0-34431deaa605

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
@MuntasirSZN
Copy link
Copy Markdown
Owner

@copilot This is good yet fragile. We are doing manual parsing. Use cssparser or a true parser to handle this. (Less fragile). Also drop colored, use anstyle. (Much more higher level, owo-colors if even higher).

Copilot AI and others added 2 commits May 19, 2026 03:35
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/a548c440-f3dc-43ae-a8a3-101ff4bb1b11

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/a548c440-f3dc-43ae-a8a3-101ff4bb1b11

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
@MuntasirSZN
Copy link
Copy Markdown
Owner

Use cssparser-color for named colors @copilot

Also drop config.schema.toml. use schemars to generate json schema in config dir (and add docs so user uses that) (taplo and tombi).

Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/a548c440-f3dc-43ae-a8a3-101ff4bb1b11

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 19, 2026

@copilot This is good yet fragile. We are doing manual parsing. Use cssparser or a true parser to handle this. (Less fragile). Also drop colored, use anstyle. (Much more higher level, owo-colors if ev...

Addressed in c8f6899. Gradient/color parsing now goes through cssparser token parsing instead of manual string parsing, and terminal styling was switched from colored to anstyle while preserving the existing output behavior.

Agent-Logs-Url: https://github.com/MuntasirSZN/getquotes/sessions/6ba4db12-82b0-4662-a411-1324af138242

Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
@MuntasirSZN MuntasirSZN merged commit cee3825 into main May 19, 2026
12 checks passed
@MuntasirSZN MuntasirSZN deleted the copilot/add-hsl-rgb-support-and-box-layout branch May 19, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants