-
Notifications
You must be signed in to change notification settings - Fork 25
InatExport #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JoeCohen
wants to merge
36
commits into
main
Choose a base branch
from
jdc_inat_export_one
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
InatExport #3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes test and routes
- Includes migration, test skeleton
- includes helpers, translation strings
Collaborator
- DRYs import and export controller tests
- `inat_id` will be set when it's exported, so no need to check Observation.notes
- Add inat_exports fixture file - Tweak observations filters, adding some nil `inat_id` entries to
- fixes CI test failures
- `create` sets @inat_export attributes - Form action includes `mo_ids` param - Revises tests - Includes `mo_id` param where appropriate - Add new tests - Unskips and fixes some tests - Deletes some irrelevant skipped tests
- Fixes CI test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.