-
Notifications
You must be signed in to change notification settings - Fork 14
add 0.38.7 winget manifest #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
manifests/m/MutagenModding/Spriggit/0.38.7/MutagenModding.Spriggit.installer.yaml
Show resolved
Hide resolved
|
Thanks for the PR! Can you walk me through the steps needed the next time spriggit is updated? Just run that one command and good to go?
Hmm, might complicate things. For ex, normally I work work work, make commits yada yada. Then randomly decide "time to push a version!" and create a github release that targets the latest commit tip and creates the executables. We can have that release CI run that Who is the target audience for this winget? I see we've chosen the CLI to be installed. Would some users want the UI instead? Or are UIs not typically not done via winget? (I havent used it much myself) |
|
Let's maybe adjust the CI files in this PR too? We can merge this in, make the winget repo PR, and then push a new spriggit version here and see if it all updates as we expect? |
Yeah to be honest I think we can skip committing them. If this PR is "approved" I can close it and create the PR into
The audience I had in mind are the less technical modders (artists, writers, etc.) who use Spriggit with a team but wouldn't want to be burdened with putting a zip somewhere, setting PATH etc. The UI is definitely possible to also add, I have to dig a little more. I have an uncommitted Wix Toolset project for an MSI that installs both the UI and CLI, sets PATH and adds a start menu shortcut. That MSI could be used to install straight from the MSI itself or used by winget to install the UI and make the start menu shortcut. I also want to see if |
|
@Noggog i updated the
|
Sounds good
Cool! I think the only reason to maybe figure it out earlier rather than later is just so that the winget registry naming makes sense. is
Done https://github.com/Mutagen-Modding/winget-pkgs
Does this token need write access to make commits, i imagine? |
I think the CLI is the only thing people would realistically launch from the command line so I don't think we need to alias it. The way 7zip does this and I guess we can do it too is the installer just installs everything, UI and CLI. I can commit the wix project I made for the installer and instead of winget using the .zip it can use the .msi that Wix produces. If you want to alias it adding "-ui" or "-cli" to the end seems logical to me.
As long as I can make PRs I should be good!
The docs just said |
|
@Noggog I've had some more thoughts on the UI vs. CLI. I think we should make separate packages for them. The installation of the UI is more complex because we need to make the start menu. In addition we also will have two separate .exe's and I don't think it will correctly be able to alias them as a result. I will draft up a manifest for the UI but we first need to get #127 merged. |
|
Added the manifests to the mutagen fork of winget here |
Sweet! Looks like I do need to be a collaborator to make the PR, if that's alright. |
|
Pushing out 0.38.8 that returns |
|
We'red we leave this off? Do you think we'd be able to redo the winget PR and get approved with the new status return code in 0.38.8 @yak3d ? |
It finally passed validation. Just awaiting moderator approval now. |

This would be the first winget manifest. We can update https://github.com/Mutagen-Modding/Spriggit/blob/dev/.github/workflows/ci-publish.yml to call:
This will automatically make the new manifest and push the PR to https://github.com/microsoft/winget-pkgs for the new version. For this original version, we'll need to make the PR on
winget-pkgsafter this manifest is merged. I don't even think we even need the manifests in spriggit but it would be nice to keep them.