feat(oss): support cross-account assume role credentials - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The new test environment will run on ECS in a different Alibaba Cloud account, while continuing to access OSS in the original account. The existing OSS credential implementation only supports static credentials and same-account ECS RAM Role credentials, so it cannot support the required cross-account role chain.
Main Changes
ecs_ram_role_assume_role.staticandecs_ram_rolebehavior unchanged.Impact
staticorecs_ram_roleare not expected to change behavior.oss.credential_modeis set toecs_ram_role_assume_role.Verification
Local checks completed:
make -f Makefile/makefile fmt: passedmake -f Makefile/makefile lint: passedmake -f Makefile/makefile test: passedmake -f Makefile/makefile it: passedgo test ./internal/config ./internal/platform/oss: passedGOOS=linux go test -c -o NUL ./internal/platform/oss: passedgit diff --check: passed