BKAWALIOS-64: Refactor onboarding in terms of code quality#1
Open
Alienuser wants to merge 5 commits intodevelopmentfrom
Open
BKAWALIOS-64: Refactor onboarding in terms of code quality#1Alienuser wants to merge 5 commits intodevelopmentfrom
Alienuser wants to merge 5 commits intodevelopmentfrom
Conversation
Alienuser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor onboarding in terms of
design: according to PO approved design screens
technical implementation: according to mutually agreed (Lars, Moritz, Michael) approach
How to test
Does not include functional changes
Verify that the visual appearance of the onboarding procedure matches sketch
Review the code changes:
Usage of centralised theming, view creation, binding and layout has been removed
Consistent use of the Constants/Styles, ImageNameIdentifier and color constants from new Assets
Simplified layouts (ability to change layouts, clumsy constructs removed