-
Notifications
You must be signed in to change notification settings - Fork 0
Add post sync hook for triggering tests #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n handling. Rename files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new feature allowing the configuration of automated test jobs via a Helm chart for the mycarrier application. Key changes include adding a new testtrigger configuration section in values.yaml, implementing tests in triggertests_test.yaml, and introducing new templates (triggertestengine.yaml and _spec_triggertestengine.tpl) to generate Kubernetes Job resources for test triggers.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
charts/mycarrier-helm/values.yaml | Added detailed comments for testtrigger configuration |
charts/mycarrier-helm/tests/triggertests_test.yaml | Introduced comprehensive tests for validating testtrigger jobs |
charts/mycarrier-helm/templates/triggertestengine.yaml | Created a new template for generating Kubernetes Job resources |
charts/mycarrier-helm/templates/_spec_triggertestengine.tpl | Defined the test engine hook specifications with a typo issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new feature to configure automated test jobs for the mycarrier Helm chart via a post-sync hook. Key changes include:
- Adding testtrigger configuration documentation in values.yaml
- Implementing test job resource generation in new templates (triggertestengine.yaml and _spec_triggertestengine.tpl)
- Introducing a comprehensive test suite in triggertests_test.yaml to validate the feature
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
charts/mycarrier-helm/values.yaml | Added documentation for testtrigger configuration parameters |
charts/mycarrier-helm/tests/triggertests_test.yaml | Added tests to verify job creation and configuration for testtrigger |
charts/mycarrier-helm/templates/triggertestengine.yaml | Defined the Job resource using testtrigger configuration |
charts/mycarrier-helm/templates/_spec_triggertestengine.tpl | Defined the test engine hook specifications with configurable parameters |
Co-authored-by: Copilot <[email protected]>
This pull request introduces a new feature for configuring automated test jobs (
testtrigger
) in the Helm chart for themycarrier
application. It includes template changes, test cases, and documentation updates to support the feature.New Feature: Test Trigger Configuration
Template Enhancements:
_spec_triggertestengine.tpl
to define thetesttrigger
job specifications, including configurable properties likettlSecondsAfterFinished
,activeDeadlineSeconds
, andbackoffLimit
. It also supports dynamic test definitions usingcurl
commands for API calls.triggertestengine.yaml
to generate KubernetesJob
resources for each application based on thetesttrigger
configuration. This includes labels, annotations, and integration with ArgoCD hooks.Testing:
triggertests_test.yaml
to validate thetesttrigger
functionality. Tests include:Documentation:
values.yaml
with detailed comments on thetesttrigger
configuration, explaining the available options and structure for defining test jobs and filters.