Skip to content

Conversation

smunukutla-mycarrier
Copy link
Contributor

This pull request introduces a new feature for configuring automated test jobs (testtrigger) in the Helm chart for the mycarrier application. It includes template changes, test cases, and documentation updates to support the feature.

New Feature: Test Trigger Configuration

Template Enhancements:

  • Added a reusable Helm template _spec_triggertestengine.tpl to define the testtrigger job specifications, including configurable properties like ttlSecondsAfterFinished, activeDeadlineSeconds, and backoffLimit. It also supports dynamic test definitions using curl commands for API calls.
  • Created a new template triggertestengine.yaml to generate Kubernetes Job resources for each application based on the testtrigger configuration. This includes labels, annotations, and integration with ArgoCD hooks.

Testing:

  • Introduced a comprehensive test suite in triggertests_test.yaml to validate the testtrigger functionality. Tests include:
    • Ensuring jobs are created for enabled applications.
    • Verifying proper labels, annotations, and specifications.
    • Handling edge cases like multiple test definitions, special characters in filter values, custom TTLs, and empty filters.

Documentation:

  • Updated values.yaml with detailed comments on the testtrigger configuration, explaining the available options and structure for defining test jobs and filters.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature allowing the configuration of automated test jobs via a Helm chart for the mycarrier application. Key changes include adding a new testtrigger configuration section in values.yaml, implementing tests in triggertests_test.yaml, and introducing new templates (triggertestengine.yaml and _spec_triggertestengine.tpl) to generate Kubernetes Job resources for test triggers.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
charts/mycarrier-helm/values.yaml Added detailed comments for testtrigger configuration
charts/mycarrier-helm/tests/triggertests_test.yaml Introduced comprehensive tests for validating testtrigger jobs
charts/mycarrier-helm/templates/triggertestengine.yaml Created a new template for generating Kubernetes Job resources
charts/mycarrier-helm/templates/_spec_triggertestengine.tpl Defined the test engine hook specifications with a typo issue

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new feature to configure automated test jobs for the mycarrier Helm chart via a post-sync hook. Key changes include:

  • Adding testtrigger configuration documentation in values.yaml
  • Implementing test job resource generation in new templates (triggertestengine.yaml and _spec_triggertestengine.tpl)
  • Introducing a comprehensive test suite in triggertests_test.yaml to validate the feature

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File Description
charts/mycarrier-helm/values.yaml Added documentation for testtrigger configuration parameters
charts/mycarrier-helm/tests/triggertests_test.yaml Added tests to verify job creation and configuration for testtrigger
charts/mycarrier-helm/templates/triggertestengine.yaml Defined the Job resource using testtrigger configuration
charts/mycarrier-helm/templates/_spec_triggertestengine.tpl Defined the test engine hook specifications with configurable parameters

@MyCarrier-DevOps MyCarrier-DevOps deleted a comment from Copilot AI May 14, 2025
@smunukutla-mycarrier smunukutla-mycarrier merged commit 5f89dd3 into main May 14, 2025
1 check failed
@smunukutla-mycarrier smunukutla-mycarrier deleted the add-post-sync-hook branch September 3, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants