Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec24681146
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <xsl:value-of select="concat('&_xed_session=', $xedSession)" /> | ||
| <xsl:value-of select="concat('&@xlink:href=', $objectID)" /> |
There was a problem hiding this comment.
The new subselect link concatenates _xed_session and @xlink:href directly into the query string without encoding, so values containing reserved characters (for example when the source edit URL has additional query params after id=) will be split by &/+ and produce a malformed XEditor URL or a truncated object id. The previous implementation encoded both values before appending; this should be preserved to keep the takeover action reliable across mapped editor URLs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Neither $xedSession ({int}-{int}) nor an $objectID(foo_bar_{int}) will ever contain special characters. Adding an encoding step acts like a NOOP here.
rsteph-de
left a comment
rsteph-de
left a comment
There was a problem hiding this comment.
some "technical" issues ...
This should be reviewed by a real MIR user (not me ;-) ).
Still, I suggest to merge ASAP and fix possible remaining issues later.
yagee-de
force-pushed
the
issues/MIR-1556-migrate-solr-response
branch
from
ec24681 to
5b20604
Compare
kkrebs
left a comment
kkrebs
left a comment
There was a problem hiding this comment.
looks good for me, but please take a look at the chatgpt suggestion
yagee-de
force-pushed
the
issues/MIR-1556-migrate-solr-response
branch
from
5b20604 to
082b575
Compare
3 participants
Link to jira.
requires MyCoRe-Org/mycore#2873