Mocha is a dev dep #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

taylorjdawson wants to merge 1 commit into MyEtherWallet:master from taylorjdawson:patch-1

taylorjdawson commented Jul 1, 2022 •

edited

Loading

Having a dev dep as a dep causes issue like so

minimist is used in mocha and since it is for testing only there is no security threat to users of the npm module.

Also the mocha version used is 5 major versions behind. Mocha is at v10 now.


          Mocha is a dev dep

119ce83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet