Open
Conversation
TheLastProject
requested changes
Mar 22, 2020
| # n: automatically update on Mycroft launch | ||
| # y: add helper commands to PATH | ||
| # n: check code style when submitting | ||
| ARG WIZARD_SEQUENCE=ynyn |
Collaborator
There was a problem hiding this comment.
While clever, this is very fragile. I feel anything limiting properly automating this setup should be added to the setup script (more env vars or flags, probably), and not hacked around like this.
Author
There was a problem hiding this comment.
Absolutely agree. The approach is really contrived. But being an outsider to the project I was trying to modify as little as possible.
Should I split WIZARD_SEQUENCE buildarg into 4 buildargs? For instance:
- BRANCH
- AUTO_UPDATE
- ADD_HELPERS
- CHECK_CODE
Collaborator
There was a problem hiding this comment.
Oh, I forgot to reply to this, sorry.
Well, above all, the official installer needs to be changed to accept these kind of things as environment variables so that this can be done cleanly in a way that won't break in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the whole installation process more logically organized, explicitly separating the different stages and eliminating some redundant steps.
It also implements some new build-time parameterization in order to provide some flexibility to the images being compiled.