Minor changes for compatibility to Python 3.10#242
Open
icarosadero wants to merge 10 commits intoMycroftAI:devfrom
Open
Minor changes for compatibility to Python 3.10#242icarosadero wants to merge 10 commits intoMycroftAI:devfrom
icarosadero wants to merge 10 commits intoMycroftAI:devfrom
Conversation
|
Thank you! |
Shulyaka
reviewed
Aug 23, 2023
Co-authored-by: Denis Shulyaka <Shulyaka@gmail.com>
|
I also had to replace |
```
Exception in thread Thread-1 (_handle_predictions):
Traceback (most recent call last):
File "/usr/lib64/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/usr/lib64/python3.11/threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "/home/denis/mycroft-precise/runner/precise_runner/runner.py", line 243, in _handle_predictions
self.on_activation()
File "/home/denis/mycroft-precise/precise/scripts/listen.py", line 71, in on_activation
save_audio(nm, self.audio_buffer)
File "/home/denis/mycroft-precise/precise/util.py", line 72, in save_audio
wavio.write(filename, save_audio, pr.sample_rate, sampwidth=pr.sample_depth, scale='none')
File "/home/denis/mycroft-precise/.venv/lib64/python3.11/site-packages/wavio.py", line 441, in write
raise ValueError('The scale parameter must not be set when the '
ValueError: The scale parameter must not be set when the input is an integer array. No shifting or scaling is done to integer input values.
```
|
@icarosadero I've raised PR icarosadero#1 |
added 2 commits
August 26, 2023 16:35
more updates to support newer tensorflow versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made minor changes to allow this project to run on most recent versions of TensorFlow and Python 3.10
Type of PR
If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so:
- [x]Testing
How can someone reviewing this PR test that it is working properly? Is there appropriate test coverage for this change?
Documentation
Does documentation for this already exist? Are there docstrings on all the public methods you added or modified? Have these been updated?
CLA
To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement.
This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work. Additionally, it establishes that you retain the ownership of your contributed code and intellectual property. As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.
If you haven't already signed the agreement and been added to our public Contributors repo then please head to https://mycroft.ai/cla to initiate the signing process.