add auto starter and keep watching for net share #658
38 new issues (0 max.) of at least severity.
Here is an overview of what got changed by this pull request:
Issues
======
- Added 38
Complexity increasing per file
==============================
- mobile/src/main/java/be/mygod/vpnhotspot/SettingsPreferenceFragment.kt 103
- mobile/src/main/java/be/mygod/vpnhotspot/MainActivity.kt 6
- mobile/src/main/java/be/mygod/vpnhotspot/WifiTetheringAutoStarter.kt 30
- mobile/src/main/java/be/mygod/vpnhotspot/EthernetTetheringAutoStarter.kt 30
- mobile/src/main/java/be/mygod/vpnhotspot/BluetoothTetheringAutoStarter.kt 30
- mobile/src/main/java/be/mygod/vpnhotspot/UsbTetheringAutoStarter.kt 30
- mobile/src/main/java/be/mygod/vpnhotspot/util/QRCodeGenerator.kt 10
- mobile/src/main/java/be/mygod/vpnhotspot/util/WebServerManager.kt 48
- mobile/src/main/java/be/mygod/vpnhotspot/util/ApiKeyManager.kt 19
- mobile/src/main/java/be/mygod/vpnhotspot/QRCodeScannerActivity.kt 30
- mobile/src/main/java/be/mygod/vpnhotspot/QRCodeDialog.kt 17
- mobile/src/main/java/be/mygod/vpnhotspot/RemoteControlFragment.kt 149
- mobile/src/main/java/be/mygod/vpnhotspot/OkHttpWebServer.kt 205
- tests/integration/test_webserver_http_fix.py 41
- tests/unit/verify_settings.py 6
- tests/device/test_remote_connection.py 4
- tests/unit/test_okhttp_webserver_resource_management.py 19
- tests/integration/test_crash_fix.py 33
- tests/device/test_device_functionality.py 45
- tests/integration/test_api_key_workflow.py 31
- tests/integration/test_clipboard_error_handling.py 31
- tests/device/test_connection_simple.py 5
- tests/unit/test_webserver_manager.py 21
- tests/integration/test_all_webserver_fixes.py 52
- mobile/src/main/java/be/mygod/vpnhotspot/util/AutoConnectTester.kt 6
Clones added
============
- mobile/src/main/java/be/mygod/vpnhotspot/SettingsPreferenceFragment.kt 8
- mobile/src/main/java/be/mygod/vpnhotspot/WifiTetheringAutoStarter.kt 11
- mobile/src/main/java/be/mygod/vpnhotspot/EthernetTetheringAutoStarter.kt 4
- mobile/src/main/java/be/mygod/vpnhotspot/BluetoothTetheringAutoStarter.kt 5
- mobile/src/main/java/be/mygod/vpnhotspot/UsbTetheringAutoStarter.kt 8
- mobile/src/main/java/be/mygod/vpnhotspot/util/QRCodeGenerator.kt 4
- mobile/src/main/java/be/mygod/vpnhotspot/QRCodeDialog.kt 2
- mobile/src/main/java/be/mygod/vpnhotspot/RemoteControlFragment.kt 20
- tests/integration/test_webserver_http_fix.py 3
- tests/integration/test_crash_fix.py 3
- tests/device/test_device_functionality.py 1
- tests/integration/test_api_key_workflow.py 2
See the complete overview on Codacy
Annotations
Check notice on line 10 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L10
Consider possible security implications associated with the subprocess module.
Check warning on line 50 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L50
Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Check warning on line 91 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L91
Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Check warning on line 122 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L122
Starting a process with a partial executable path
Check warning on line 122 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L122
subprocess call - check for execution of untrusted input.
Check warning on line 137 in tests/device/test_connection_simple.py
codacy-production / Codacy Static Code Analysis
tests/device/test_connection_simple.py#L137
subprocess call - check for execution of untrusted input.
Check notice on line 10 in tests/device/test_remote_connection.py
codacy-production / Codacy Static Code Analysis
tests/device/test_remote_connection.py#L10
Consider possible security implications associated with the subprocess module.
Check warning on line 89 in tests/device/test_remote_connection.py
codacy-production / Codacy Static Code Analysis
tests/device/test_remote_connection.py#L89
Starting a process with a partial executable path
Check warning on line 113 in tests/device/test_remote_connection.py
codacy-production / Codacy Static Code Analysis
tests/device/test_remote_connection.py#L113
Starting a process with a partial executable path
Check warning on line 113 in tests/device/test_remote_connection.py
codacy-production / Codacy Static Code Analysis
tests/device/test_remote_connection.py#L113
subprocess call - check for execution of untrusted input.
Check warning on line 119 in tests/device/test_remote_connection.py
codacy-production / Codacy Static Code Analysis
tests/device/test_remote_connection.py#L119
Starting a process with a partial executable path
Check notice on line 185 in tests/integration/test_all_webserver_fixes.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_all_webserver_fixes.py#L185
Consider possible security implications associated with the subprocess module.
Check warning on line 193 in tests/integration/test_all_webserver_fixes.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_all_webserver_fixes.py#L193
subprocess call - check for execution of untrusted input.
Check notice on line 6 in tests/integration/test_api_key_workflow.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_api_key_workflow.py#L6
Consider possible security implications associated with the subprocess module.
Check warning on line 25 in tests/integration/test_api_key_workflow.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_api_key_workflow.py#L25
Starting a process with a partial executable path
Check notice on line 6 in tests/integration/test_crash_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_crash_fix.py#L6
Consider possible security implications associated with the subprocess module.
Check warning on line 13 in tests/integration/test_crash_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_crash_fix.py#L13
subprocess call - check for execution of untrusted input.
Check warning on line 90 in tests/integration/test_crash_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_crash_fix.py#L90
Starting a process with a partial executable path
Check warning on line 90 in tests/integration/test_crash_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_crash_fix.py#L90
subprocess call - check for execution of untrusted input.
Check notice on line 6 in tests/integration/test_webserver_http_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_webserver_http_fix.py#L6
Consider possible security implications associated with the subprocess module.
Check warning on line 14 in tests/integration/test_webserver_http_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_webserver_http_fix.py#L14
subprocess call - check for execution of untrusted input.
Check warning on line 27 in tests/integration/test_webserver_http_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_webserver_http_fix.py#L27
Starting a process with a partial executable path
Check warning on line 27 in tests/integration/test_webserver_http_fix.py
codacy-production / Codacy Static Code Analysis
tests/integration/test_webserver_http_fix.py#L27
subprocess call - check for execution of untrusted input.
Check warning on line 17 in tests/unit/test_okhttp_webserver_resource_management.py
codacy-production / Codacy Static Code Analysis
tests/unit/test_okhttp_webserver_resource_management.py#L17
subprocess call with shell=True identified, security issue.
Check warning on line 8 in tests/unit/verify_settings.py
codacy-production / Codacy Static Code Analysis
tests/unit/verify_settings.py#L8
Using xml.etree.ElementTree to parse untrusted XML data is known to be vulnerable to XML attacks. Replace xml.etree.ElementTree with the equivalent defusedxml package, or make sure defusedxml.defuse_stdlib() is called.