Crypto browserify removal attempt #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mylanos
force-pushed
the
crypto-browserify-removal-attempt
branch
4 times, most recently
from
abdbd47 to
c771cf1
Compare
Currently, the Observe section is only shown to users which have the `PROMETHEUS`, `MONITORING` and `CAN_GET_NS` flags. Some dynamic plugins, for example distributed tracing and logging, add a new link to the Observe section, which should be visible to all users - even without the `PROMETHEUS`, `MONITORING` and `CAN_GET_NS` flags. Therefore this PR removes the requirement on this flags. I checked the links in the section, and the monitoring-related links (Alerting, Metrics, Dashboards, Targets) set the required permissions (`PROMETHEUS`, `MONITORING` and `CAN_GET_NS`) on the `console.navigation/href` already: https://github.com/openshift/monitoring-plugin/blob/6b92084514ea9007d7d797f7699eab19e0c2f2fc/web/console-extensions.json In case the Observe section is empty, it is hidden: https://github.com/openshift/console/blob/855f949121cefb3ea63b17ebf91e6bdcdc60d9c8/frontend/packages/console-app/src/components/nav/NavSection.tsx#L57-L60 Signed-off-by: Andreas Gerstmayr <[email protected]>
…e the typing definitions, rename to OpaqueSecretFormEntry
…t, decouple some of the functions to utils file, rename the component to OpaqueSecretForm.tsx, consolidate typings
bug has been fixed and I verified that the Create project button in the footer can be accessed through keyboard
I can no longer observe a runtime error when opening this menu up, so I think it's safe to remove
Remove `umd-compat-loader`
openshift#14681) * OCPBUGS-45371: Fix issue where TokenReview was not working as expected We expected the console service account bearer token to be present on the internal k8s REST configuration, but it was not. This caused all TokenReview requests to be skipped since no bearer token was available to make the requests. Also, we found that adding token review requests to all authenticated requests caused some performance issues, so we added token review only to endpoints affected by this bug. - Update OpenShift authenticator to use a k8s client-go Clientset to make TokenReview requests. This Clientset is configured using the same REST config that the main server uses to proxy console service account delegated requests, meaning whatever console service account bearer token is configured on the main server is the same one used for TokenReview requests. - Update main.go to accept an off-cluster bearer token, which is used to make console service account delegated requests in an off-cluster, auth-enabled environment. - Update the README instructions for auth-enabled dev environments to include setting up a console service account API token and consume it through the new bridge arg. - Update `examples/run-bridge.sh` to consume an off-cluster service acccount token file - Move token review to the parent Authenticator interface so that it can be used as a middleware funciton - Add a middleware function for token review - Add token review middleware to endpoints affected by this bug * Address PR review comments * nits
ODC-7727: Favoriting page in the Console admin perspective
…name-on-resource-list-page-doesnt-align-chinese-japanese-korean OCPBUGS-51372: Filter 'Name' on resource list page doesn't align well when language is set to Chinese/Japanese/Korean
…rumbs OCPBUGS-52298: Add breadcrumbs to ODC Project details page
CONSOLE-4503: Replace custom Banner with PatternFly equivalent
CONSOLE-4409: Update monaco theming and sidebar logic
https://issues.redhat.com/browse/ODC-7727 follow on ticket to add a hover effect to the add to favourites button, by using the CSS from the ODC topology quick search button before  after  /assign @lokanandaprabhu adding labels for already approved ticket /label px-approved /label qe-approved /label docs-approved
OCPBUGS-52214: add missing v5 patternfly-addons.scss and patternfly-charts.scss styles
OCPBUGS-52316: enable clicking outside NodeLogs Selects to close them
OCPBUGS-37101: Remove logoutOpenShift method call
OCPBUGS-49348: Fix Secret form drag and drop issue
…GS-48491 OCPBUGS-48491: Namespace is not persisting when switching to developer view from the topology page of admin page
CONSOLE-4504: set LogViewer theme using console's theme
ODC-7727: Add hover effect to favourites icon
Mylanos
force-pushed
the
crypto-browserify-removal-attempt
branch
6 times, most recently
from
735c311 to
57070a7
Compare
…functions from the Crypto object
Mylanos
force-pushed
the
crypto-browserify-removal-attempt
branch
2 times, most recently
from
d36f7b2 to
afdc956
Compare
…h handling improvements.
Mylanos
force-pushed
the
crypto-browserify-removal-attempt
branch
3 times, most recently
from
dfb73a4 to
4972cf3
Compare
…metry-plugin to use browsers crypto, refactor
Mylanos
force-pushed
the
crypto-browserify-removal-attempt
branch
from
4972cf3 to
97a6df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.