fix: goto def jumping to runtime callee for complex let bindings

[hongjr03]

Fixes the regression introduced in #1904: GotoDefinition allowed dynamic analysis to override static bindings, causing definitions to resolve to runtime value origins instead of identifier bindings, which does not match its semantics.

Closes #2315.

[gemini-code-assist]

Summary of Changes

Hello @hongjr03, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical regression in the GotoDefinition feature, which previously caused incorrect navigation by prioritizing dynamic runtime analysis over static identifier bindings. The core change involves updating the goto_definition.rs logic to ensure that symbol definitions are consistently resolved to their static declarations. This enhancement improves the accuracy and reliability of code navigation, especially for complex let expressions, and is validated by newly added test cases.

Highlights

• Regression Fix: Addressed a regression where GotoDefinition incorrectly resolved to runtime value origins instead of static identifier bindings, particularly for complex let expressions.
• Static Binding Enforcement: Modified the goto_definition.rs implementation to explicitly use def_of_syntax, ensuring that GotoDefinition prioritizes static analysis over dynamic analysis for symbol resolution.
• New Test Cases: Introduced new test files (complex_let_binding.typ and its snapshot) to validate the corrected GotoDefinition behavior for intricate let bindings, confirming the fix.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a regression in 'Go to Definition' functionality for complex let bindings. The change is straightforward and correct: it switches from a definition resolution function that includes dynamic analysis (def_of_syntax_or_dyn) to one that relies purely on static analysis (def_of_syntax). This ensures that 'Go to Definition' consistently navigates to the static declaration of an identifier, which aligns with user expectations and standard language server behavior. The fix is validated by a new, well-crafted test case that reproduces the problematic scenario. The changes are clean, targeted, and I have no further suggestions for improvement.