fix: switch to gen-lsp-types - #2494
Conversation
|
See rust-lang/rust-analyzer#22115 and wgsl-analyzer/wgsl-analyzer#1090 for other migration considerations |
Myriad-Dreamin
left a comment
Myriad-Dreamin
left a comment
There was a problem hiding this comment.
Hi, thanks for the awesome gen-lsp-types crate. I really appreciate you providing a replacement for the unmaintained lsp-types. I've left two comments, but they shouldn't block merging.
|
I'm drafting another release of the library which contains a metamodel update (supporting new markdown diagnostic messages) and allows for request/notification enums to be created without ownership, meaning no unnecessary allocations. Will mark this PR as ready once the release is cut and everything seems to be working 👍 |
|
I've pushed a new version of the library, which should remove the need for the allocations as mentioned above. Also, the request/notification method newtype is now |
[gen-lsp-types](https://github.com/ribru17/gen-lsp-types) is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness. lsp-types issues fixed in gen-lsp-types: - gluon-lang/lsp-types#310 - gluon-lang/lsp-types#308 - gluon-lang/lsp-types#284 - gluon-lang/lsp-types#278 - gluon-lang/lsp-types#277 - gluon-lang/lsp-types#260 - gluon-lang/lsp-types#245 - gluon-lang/lsp-types#93 Closes Myriad-Dreamin#1542 (as an alternative solution)
|
@Myriad-Dreamin I've resolved the conflicts for this change and bumped to the latest library version (in case you're still interested in this change) |
|
@ribru17 I didn't forget this PR. we are just processing bump the main upstream typst from v0.14 to v0.15. This just happens once a year, :). |
|
No worries or rush- that's exciting! |
2 participants
gen-lsp-types is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness.
lsp-types issues fixed in gen-lsp-types:
SnippetTextEditsupport (proposed) gluon-lang/lsp-types#310Uritype in 0.96.0 is hard to use and have almost no interoperability gluon-lang/lsp-types#284DefaultforCodeActionOptionsgluon-lang/lsp-types#260Closes #1542 (as an alternative solution)