fix(query): surface traced diagnostics at main callsites - #2677
Open
GeronimoCastano wants to merge 1 commit into
Open
fix(query): surface traced diagnostics at main callsites#2677GeronimoCastano wants to merge 1 commit into
GeronimoCastano wants to merge 1 commit into
Conversation
GeronimoCastano
marked this pull request as ready for review
July 28, 2026 23:20
GeronimoCastano
requested review from
Enter-tainer and
Myriad-Dreamin
as code owners
July 28, 2026 23:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Typst reports an error inside an imported module or package, Tinymist assigns the primary LSP diagnostic to the internal source span and sends the user callsite through
relatedInformation.VS Code lists the diagnostic in the Problems panel, but Error Lens cannot display it beside the call that caused the error. Neovim clients have the same problem when they do not expose
relatedInformation.This change uses the outermost trace span in the main document as the displayed diagnostic location when the original error comes from another file. It keeps the original source location in
relatedInformationwith the messagediagnostic originated here.Diagnostics that originate in the main document keep their current location.
Tests
Added diagnostic fixtures covering:
Ran:
cargo test -p tinymist-querycargo build -p tinymist-cli --releaseAddresses #1870.