Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,9 @@ typstyle-core = { git = "https://github.com/Myriad-Dreamin/typstyle.git", rev =
# reflexo-typst = { git = "https://github.com/Myriad-Dreamin/typst.ts.git", rev = "bd58ec034584828c272fac1b842acad5b1d79e61" }
# reflexo-vec2svg = { git = "https://github.com/Myriad-Dreamin/typst.ts.git", rev = "bd58ec034584828c272fac1b842acad5b1d79e61" }

# These patches use local `reflexo` for development.
# reflexo = { path = "../typst.ts/crates/reflexo/" }
# reflexo-typst = { path = "../typst.ts/crates/reflexo-typst/" }
# reflexo-vec2svg = { path = "../typst.ts/crates/conversion/vec2svg/" }
reflexo = { git = "https://github.com/syrkis/typst.ts.git", rev = "aff5118373569e25a01ce68ce65fd96472bd369f" }
reflexo-typst = { git = "https://github.com/syrkis/typst.ts.git", rev = "aff5118373569e25a01ce68ce65fd96472bd369f" }
reflexo-vec2svg = { git = "https://github.com/syrkis/typst.ts.git", rev = "aff5118373569e25a01ce68ce65fd96472bd369f" }

typst-shim = { path = "crates/typst-shim" }
tinymist-analysis = { path = "crates/tinymist-analysis" }
Expand Down
3 changes: 2 additions & 1 deletion crates/tinymist-task/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ notify.workspace = true
parking_lot.workspace = true
rayon.workspace = true
rpds.workspace = true
reflexo-vec2svg.workspace = true
semver.workspace = true
serde.workspace = true
serde_json.workspace = true
Expand All @@ -47,7 +48,7 @@ typst-svg.workspace = true
[features]

default = ["pdf", "text"]
no-content-hint = []
no-content-hint = ["reflexo-vec2svg/no-content-hint"]

pdf = ["dep:chrono"]
text = []
Expand Down
178 changes: 147 additions & 31 deletions crates/tinymist-task/src/compute/svg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

use std::sync::Arc;

use reflexo_vec2svg::{SvgExportFeature, SvgExporter};
use tinymist_std::error::prelude::*;
use tinymist_std::typst::TypstPagedDocument;
use tinymist_world::{CompilerFeat, ExportComputation, WorldComputeGraph};
use typst::model::Document;

use crate::compute::{parse_length, select_pages};
use crate::model::ExportSvgTask;
Expand All @@ -23,37 +23,47 @@ impl<F: CompilerFeat> ExportComputation<F, TypstPagedDocument> for SvgExport {
doc: &Arc<TypstPagedDocument>,
config: &ExportSvgTask,
) -> Result<Self::Output> {
let svg_options = typst_svg::SvgOptions::default();
let exported_pages = select_pages(doc, &config.pages);
if let Some(PageMerge { ref gap }) = config.merge {
// Typst does not expose svg-merging API.
// Therefore, we have to create a dummy document here.
let dummy_doc = TypstPagedDocument::new(
exported_pages
.into_iter()
.map(|(_, page)| page.clone())
.collect(),
doc.info().clone(),
);
let gap = gap
.as_ref()
.and_then(|gap| parse_length(gap).ok())
.unwrap_or_default();
let svg = typst_svg::svg_merged(&dummy_doc, &svg_options, gap);
Ok(ImageOutput::Merged(svg))
} else {
let exported = exported_pages
.into_iter()
.map(|(i, page)| {
let svg = typst_svg::svg(page, &svg_options);
Ok(PagedOutput {
page: i,
value: svg,
})
})
.collect::<Result<Vec<_>>>()?;
Ok(ImageOutput::Paged(exported))
render(doc, config)
}
}

fn render(doc: &TypstPagedDocument, config: &ExportSvgTask) -> Result<ImageOutput<String>> {
let exported_pages = select_pages(doc, &config.pages);
let mut vector_doc = SvgExporter::<SvgExportFeature>::svg_doc(doc);
vector_doc.module.prepare_glyphs();
if let Some(PageMerge { ref gap }) = config.merge {
let gap = gap
.as_ref()
.and_then(|gap| parse_length(gap).ok())
.unwrap_or_default()
.to_pt() as f32;
let mut pages = exported_pages
.into_iter()
.map(|(i, _)| vector_doc.pages[i].clone())
.collect::<Vec<_>>();
let last = pages.len().saturating_sub(1);
for page in pages.iter_mut().take(last) {
page.size.y.0 += gap;
}
Ok(ImageOutput::Merged(
SvgExporter::<SvgExportFeature>::render_flat_svg(&vector_doc.module, &pages, None),
))
} else {
let exported = exported_pages
.into_iter()
.map(|(i, _)| {
let svg = SvgExporter::<SvgExportFeature>::render_flat_svg(
&vector_doc.module,
std::slice::from_ref(&vector_doc.pages[i]),
None,
);
Ok(PagedOutput {
page: i,
value: svg,
})
})
.collect::<Result<Vec<_>>>()?;
Ok(ImageOutput::Paged(exported))
}
}

Expand All @@ -64,3 +74,109 @@ impl<F: CompilerFeat> ExportComputation<F, TypstPagedDocument> for SvgExport {
// OptionDocumentTask::run_export::<F, Self>(graph)
// }
// }

#[cfg(test)]
mod tests {
use std::str::FromStr;

use ecow::eco_vec;
use typst::foundations::{Bytes, Content, Smart};
use typst::layout::{Abs, Frame, FrameItem, Point, Sides, Size};
use typst::syntax::Span;
use typst::visualize::{ExchangeFormat, Image, RasterImage};
use typst_layout::Page;

use super::*;
use crate::Pages;

fn page(width: f64, height: f64, number: u64) -> Page {
Page {
frame: Frame::soft(Size::new(Abs::pt(width), Abs::pt(height))),
bleed: Sides::default(),
fill: Smart::Auto,
numbering: None,
supplement: Content::default(),
number,
}
}

fn document() -> TypstPagedDocument {
TypstPagedDocument::new(
eco_vec![page(10.0, 30.0, 1), page(20.0, 40.0, 2)],
Default::default(),
)
}

#[test]
fn renders_pages_separately() {
let ImageOutput::Paged(pages) = render(&document(), &ExportSvgTask::default()).unwrap()
else {
panic!("expected paged SVG output");
};

assert_eq!(pages.len(), 2);
assert_eq!(pages[0].page, 0);
assert!(pages[0].value.contains(r#"viewBox="0 0 10.000 30.000""#));
assert_eq!(pages[1].page, 1);
assert!(pages[1].value.contains(r#"viewBox="0 0 20.000 40.000""#));
}

#[test]
fn renders_only_selected_pages() {
let config = ExportSvgTask {
pages: Some(vec![Pages::from_str("2").unwrap()]),
..Default::default()
};
let ImageOutput::Paged(pages) = render(&document(), &config).unwrap() else {
panic!("expected paged SVG output");
};

assert_eq!(pages.len(), 1);
assert_eq!(pages[0].page, 1);
assert!(pages[0].value.contains(r#"viewBox="0 0 20.000 40.000""#));
}

#[test]
fn merges_pages_with_configured_gap() {
let config = ExportSvgTask {
merge: Some(PageMerge {
gap: Some("5pt".into()),
}),
..Default::default()
};
let ImageOutput::Merged(svg) = render(&document(), &config).unwrap() else {
panic!("expected merged SVG output");
};

assert!(svg.contains(r#"viewBox="0 0 20.000 75.000""#));
}

#[test]
fn deduplicates_repeated_raster_images() {
let data = Bytes::new(include_bytes!(
"../../../../editors/vscode/icons/typst-small.png"
));
let image = Image::plain(RasterImage::plain(data, ExchangeFormat::Png).unwrap());
let image_size = Size::new(Abs::pt(10.0), Abs::pt(10.0));
let mut page = page(40.0, 20.0, 1);
page.frame.push(
Point::zero(),
FrameItem::Image(image.clone(), image_size, Span::detached()),
);
page.frame.push(
Point::new(Abs::pt(20.0), Abs::zero()),
FrameItem::Image(image, image_size, Span::detached()),
);
let document = TypstPagedDocument::new(eco_vec![page], Default::default());

let ImageOutput::Paged(pages) = render(&document, &ExportSvgTask::default()).unwrap()
else {
panic!("expected paged SVG output");
};
let svg = &pages[0].value;

assert_eq!(svg.matches("data:image/png;base64,").count(), 1);
assert_eq!(svg.matches(r#"<image id="i"#).count(), 1);
assert_eq!(svg.matches(r#"<use class="typst-image"#).count(), 2);
}
}
2 changes: 2 additions & 0 deletions openspec/changes/use-reflexo-svg-exporter/.openspec.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
created: 2026-08-05
Loading