fix: skip instead of error for jwk parsing #858
Merged
+56
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyqvq
force-pushed
the
joy/update-jwk-fetch
branch
from
88d0356 to
3dda0e3
Compare
mskd12
approved these changes
Jul 15, 2025
joyqvq
force-pushed
the
joy/update-jwk-fetch
branch
from
3dda0e3 to
9bd008b
Compare
joyqvq
force-pushed
the
joy/update-jwk-fetch
branch
from
9bd008b to
f21158d
Compare
benr-ml
approved these changes
Jul 16, 2025
Collaborator
Author
|
force merging since the test failing is unrelated, and requires a prover deploy - @after-ephemera is looking into it. |
7 tasks
joyqvq
added a commit
to MystenLabs/sui
that referenced
this pull request
Jul 22, 2025
## Description we used to error completely if a provider has a ES256 key in addition to a RSA key. it should instead skip it and parse the valid RSA key. added to protocol config flag: MystenLabs/fastcrypto#858 ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Brucecarl
pushed a commit
to jumpblock/sui
that referenced
this pull request
Aug 8, 2025
## Description we used to error completely if a provider has a ES256 key in addition to a RSA key. it should instead skip it and parse the valid RSA key. added to protocol config flag: MystenLabs/fastcrypto#858 ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.